r/aws_sesv2_configuration: Fix delivery_options.max_delivery_seconds handling

[kamilturek]

Description

This PR fixes a bug when MaxDeliverySeconds was included in the API request even if not set in the configuration.

Relations

Closes #40591.

References

https://docs.aws.amazon.com/ses/latest/APIReference-V2/API_DeliveryOptions.html#SES-Type-DeliveryOptions-MaxDeliverySeconds

Output from Acceptance Testing

% make testacc PKG=sesv2 ACCTEST_PARALLELISM=1 TESTARGS="-run=TestAccSESV2ConfigurationSet_deliveryOptions"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/sesv2/... -v -count 1 -parallel 1  -run=TestAccSESV2ConfigurationSet_deliveryOptions -timeout 360m
2024/12/21 16:22:19 Initializing Terraform AWS Provider...
=== RUN   TestAccSESV2ConfigurationSet_deliveryOptions
=== PAUSE TestAccSESV2ConfigurationSet_deliveryOptions
=== CONT  TestAccSESV2ConfigurationSet_deliveryOptions
--- PASS: TestAccSESV2ConfigurationSet_deliveryOptions (39.83s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sesv2      44.954s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[stefanfreitag]

Hi @kamilturek,

thanks for raising the pull request!

I did a bit of manual testing and expandDeliveryOptions is one place to update, it resolves the issue when creating the resource. Resource updates still failed. We may need to review/ update resourceConfigurationSetUpdate, too.

[kamilturek]

Hey @stefanfreitag! Good point. This should be now fixed. Thanks.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSESV2ConfigurationSet_deliveryOptions' PKG=sesv2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/sesv2/... -v -count 1 -parallel 20  -run=TestAccSESV2ConfigurationSet_deliveryOptions -timeout 360m
2024/12/23 08:19:23 Initializing Terraform AWS Provider...
=== RUN   TestAccSESV2ConfigurationSet_deliveryOptions
=== PAUSE TestAccSESV2ConfigurationSet_deliveryOptions
=== CONT  TestAccSESV2ConfigurationSet_deliveryOptions
--- PASS: TestAccSESV2ConfigurationSet_deliveryOptions (29.42s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sesv2	34.933s

[johnsonaj]

LGTM 🚀

[ewbankkit]

@kamilturek Thanks for the contribution 🎉 👏.