Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix example code in documentation for aws_lb_trust_store #40664

Merged

Conversation

stefanfreitag
Copy link
Contributor

Description

The example listed here contains a load balancer description

[...]
resource "aws_lb_listener" "example" {
 [ ... ]
  mutual_authentication = {
    mode            = "verify"
    trust_store_arn = aws_lb_trust_store.test.arn
  }
}

with an invalid assignment mutual_authentication = {.
The PR fixes the invalid assignment

Relations

Closes #40605

References

Output from Acceptance Testing

Not applicable, only documentation is updated.

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/elbv2 Issues and PRs that pertain to the elbv2 service. needs-triage Waiting for first response or review from a maintainer. labels Dec 20, 2024
@stefanfreitag stefanfreitag marked this pull request as ready for review December 20, 2024 19:59
@stefanfreitag stefanfreitag requested a review from a team as a code owner December 20, 2024 19:59
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Dec 23, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@stefanfreitag Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit da57135 into hashicorp:main Dec 23, 2024
34 checks passed
@github-actions github-actions bot added this to the v5.83.0 milestone Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. service/elbv2 Issues and PRs that pertain to the elbv2 service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs]: aws_lb_trust_store example contains mutual_authentication argument instead of block
2 participants