Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update RDS Proxy client_password_auth_type supported auth type #40653

Merged

Conversation

yelinaung
Copy link

@yelinaung yelinaung commented Dec 20, 2024

Description

The recent aws-sdk-go-v2 RDS release adds support for MYSQL_CACHING_SHA2_PASSWORD auth type.
https://github.com/aws/aws-sdk-go-v2/blob/5a964704cb2640ed57a74b9b37a53dcda7b6b7dd/service/rds/CHANGELOG.md#v1930-2024-12-16
This updates the docs regarding the RDS Proxy client_password_auth_type supported values.

Rendered version

@yelinaung yelinaung requested a review from a team as a code owner December 20, 2024 03:00
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. needs-triage Waiting for first response or review from a maintainer. labels Dec 20, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @yelinaung 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Dec 20, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@yelinaung Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 458b0c7 into hashicorp:main Dec 20, 2024
34 checks passed
@github-actions github-actions bot added this to the v5.83.0 milestone Dec 20, 2024
@yelinaung yelinaung deleted the update-rds-proxy-supported-auth-type branch December 23, 2024 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants