Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moves API inputs off of heap #40650

Merged
merged 7 commits into from
Dec 19, 2024
Merged

Moves API inputs off of heap #40650

merged 7 commits into from
Dec 19, 2024
+295 −262

Conversation

gdavison
Copy link
Contributor

Description

Moves API inputs off of heap and onto stack for

  • accessanalyzer
  • account
  • acm
  • acmpca
  • amp
  • amplify
  • appautoscaling

@gdavison gdavison requested a review from a team as a code owner December 19, 2024 22:58
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ecs Issues and PRs that pertain to the ecs service. service/emr Issues and PRs that pertain to the emr service. service/configservice Issues and PRs that pertain to the configservice service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/apigateway Issues and PRs that pertain to the apigateway service. service/dax Issues and PRs that pertain to the dax service. service/directconnect Issues and PRs that pertain to the directconnect service. service/codebuild Issues and PRs that pertain to the codebuild service. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/acm Issues and PRs that pertain to the acm service. service/elb Issues and PRs that pertain to the elb service. service/cloudfront Issues and PRs that pertain to the cloudfront service. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. service/athena Issues and PRs that pertain to the athena service. service/codecommit Issues and PRs that pertain to the codecommit service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. service/cloudsearch Issues and PRs that pertain to the cloudsearch service. service/efs Issues and PRs that pertain to the efs service. service/budgets Issues and PRs that pertain to the budgets service. service/appsync Issues and PRs that pertain to the appsync service. service/elasticache Issues and PRs that pertain to the elasticache service. service/codepipeline Issues and PRs that pertain to the codepipeline service. service/elasticsearch Issues and PRs that pertain to the elasticsearch service. service/cloudformation Issues and PRs that pertain to the cloudformation service. service/ecr Issues and PRs that pertain to the ecr service. labels Dec 19, 2024
@gdavison gdavison removed service/devopsguru Issues and PRs that pertain to the devopsguru service. service/deploy Issues and PRs that pertain to the deploy service. service/drs Issues and PRs that pertain to the drs service. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. service/dms Issues and PRs that pertain to the dms service. service/cognitoidentity Issues and PRs that pertain to the cognitoidentity service. service/databrew Issues and PRs that pertain to the databrew service. service/cloudcontrol Issues and PRs that pertain to the cloudcontrol service. service/cur Issues and PRs that pertain to the cur service. service/customerprofiles Issues and PRs that pertain to the customerprofiles service. service/emrserverless Issues and PRs that pertain to the emrserverless service. service/controltower Issues and PRs that pertain to the controltower service. service/chimesdkmediapipelines Issues and PRs that pertain to the chimesdkmediapipelines service. service/docdbelastic Issues and PRs that pertain to the docdbelastic service. service/chimesdkvoice Issues and PRs that pertain to the chimesdkvoice service. service/cleanrooms Issues and PRs that pertain to the cleanrooms service. service/bedrock Issues and PRs that pertain to the bedrock service. service/connectcases Issues and PRs that pertain to the connectcases service. service/appfabric Issues and PRs that pertain to the appfabric service. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. service/costoptimizationhub Issues and PRs that pertain to the costoptimizationhub service. service/datazone Issues and PRs that pertain to the datazone service. service/bcmdataexports Issues and PRs that pertain to the bcmdataexports service. service/chatbot Issues and PRs that pertain to the chatbot service. service/applicationsignals Issues and PRs that pertain to the applicationsignals service. service/codeconnections Issues and PRs that pertain to the codeconnections service. labels Dec 19, 2024
johnsonaj
johnsonaj approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@gdavison gdavison merged commit 37c26fe into main Dec 19, 2024
34 checks passed
@gdavison gdavison deleted the td-more-api-inputs-in-heap branch December 19, 2024 23:59
@github-actions github-actions bot added this to the v5.83.0 milestone Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnsonaj johnsonaj johnsonaj approved these changes

Assignees
No one assigned
Labels
generators Relates to code generators. service/accessanalyzer Issues and PRs that pertain to the accessanalyzer service. service/account Issues and PRs that pertain to the account service. service/acm Issues and PRs that pertain to the acm service. service/acmpca Issues and PRs that pertain to the acmpca service. service/amp Issues and PRs that pertain to the amp service. service/amplify Issues and PRs that pertain to the amplify service. service/appautoscaling Issues and PRs that pertain to the appautoscaling service.
Projects
None yet
Milestone
v5.83.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gdavison @johnsonaj