feat: add cloudwatch log group index policy #40594

jcoelho93 · 2024-12-17T11:02:26Z

Description

Adds a aws_cloudwatch_log_index_policy resource to create log-group level field index policy.
This is a feature that was recently released by AWS: https://aws.amazon.com/about-aws/whats-new/2024/11/amazon-cloudwatch-logs-field-indexes-log-group-selection-log-insights/

Relations

Closes #40595

References

AWS documentation

Output from Acceptance Testing

I don't have a personal AWS account I can run acceptance tests on. I did run some tests and was able to:

create a log group and an index policy assigned to that log group
delete the index policy
edit the index policy (adding a new field)
edit the index policy (removing a field)
putting an invalid policy fails (a policy with no fields)
importing a index policy

github-actions · 2024-12-17T11:02:40Z

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

github-actions

Welcome @jcoelho93 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

jar-b · 2024-12-18T14:33:19Z

Hi @jcoelho93 - Thanks for your submission!

As of 2023-10-20 all net-new resources are required to use Terraform Plugin Framework. More context is available in this pinned issue and the provider contributor guide.

Once prioritized, maintainers will convert Plugin-SDK based data sources as part of the review process, but if you'd like to do the conversion in the meantime we would greatly appreciate it!

jcoelho93 · 2024-12-18T18:04:31Z

Hi @jcoelho93 - Thanks for your submission!

As of 2023-10-20 all net-new resources are required to use Terraform Plugin Framework. More context is available in this pinned issue and the provider contributor guide.

Policy Change Notice: Net-new resources/data sources will be required to be based on aws-sdk-go-v2 / terraform-plugin-framework #32917

https://hashicorp.github.io/terraform-provider-aws/terraform-plugin-development-packages/#which-plugin-version-should-i-use

Once prioritized, maintainers will convert Plugin-SDK based data sources as part of the review process, but if you'd like to do the conversion in the meantime we would greatly appreciate it!

@jar-b I've done the conversion to use the Plugin framework

% make testacc TESTARGS='-run=TestAccLogsIndexPolicy_' PKG=logs make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.23.3 test ./internal/service/logs/... -v -count 1 -parallel 20 -run=TestAccLogsIndexPolicy_ -timeout 360m 2024/12/19 12:16:31 Initializing Terraform AWS Provider... === RUN TestAccLogsIndexPolicy_basic === PAUSE TestAccLogsIndexPolicy_basic === RUN TestAccLogsIndexPolicy_disappears === PAUSE TestAccLogsIndexPolicy_disappears === RUN TestAccLogsIndexPolicy_update === PAUSE TestAccLogsIndexPolicy_update === CONT TestAccLogsIndexPolicy_basic === CONT TestAccLogsIndexPolicy_update === CONT TestAccLogsIndexPolicy_disappears --- PASS: TestAccLogsIndexPolicy_disappears (13.21s) --- PASS: TestAccLogsIndexPolicy_basic (14.48s) --- PASS: TestAccLogsIndexPolicy_update (20.38s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/logs 25.705s

…cumentSchemaRequired'.

ewbankkit

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccLogsIndexPolicy_' PKG=logs
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/logs/... -v -count 1 -parallel 20  -run=TestAccLogsIndexPolicy_ -timeout 360m
2024/12/19 12:25:38 Initializing Terraform AWS Provider...
=== RUN   TestAccLogsIndexPolicy_basic
=== PAUSE TestAccLogsIndexPolicy_basic
=== RUN   TestAccLogsIndexPolicy_disappears
=== PAUSE TestAccLogsIndexPolicy_disappears
=== RUN   TestAccLogsIndexPolicy_update
=== PAUSE TestAccLogsIndexPolicy_update
=== CONT  TestAccLogsIndexPolicy_basic
=== CONT  TestAccLogsIndexPolicy_update
=== CONT  TestAccLogsIndexPolicy_disappears
--- PASS: TestAccLogsIndexPolicy_disappears (13.40s)
--- PASS: TestAccLogsIndexPolicy_basic (14.62s)
--- PASS: TestAccLogsIndexPolicy_update (20.20s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/logs	25.595s

% make testacc TESTARGS='-run=TestAccLogsDestinationPolicy_\|TestAccLogsAccountPolicy_\|TestAccLogsDataProtectionPolicy_' PKG=logs ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/logs/... -v -count 1 -parallel 3  -run=TestAccLogsDestinationPolicy_\|TestAccLogsAccountPolicy_\|TestAccLogsDataProtectionPolicy_ -timeout 360m
2024/12/20 11:14:54 Initializing Terraform AWS Provider...
=== RUN   TestAccLogsAccountPolicy_basicSubscriptionFilter
=== PAUSE TestAccLogsAccountPolicy_basicSubscriptionFilter
=== RUN   TestAccLogsAccountPolicy_basicDataProtection
=== PAUSE TestAccLogsAccountPolicy_basicDataProtection
=== RUN   TestAccLogsAccountPolicy_disappears
=== PAUSE TestAccLogsAccountPolicy_disappears
=== RUN   TestAccLogsAccountPolicy_selectionCriteria
=== PAUSE TestAccLogsAccountPolicy_selectionCriteria
=== RUN   TestAccLogsDataProtectionPolicy_basic
=== PAUSE TestAccLogsDataProtectionPolicy_basic
=== RUN   TestAccLogsDataProtectionPolicy_disappears
=== PAUSE TestAccLogsDataProtectionPolicy_disappears
=== RUN   TestAccLogsDataProtectionPolicy_policyDocument
=== PAUSE TestAccLogsDataProtectionPolicy_policyDocument
=== RUN   TestAccLogsDestinationPolicy_basic
=== PAUSE TestAccLogsDestinationPolicy_basic
=== CONT  TestAccLogsAccountPolicy_basicSubscriptionFilter
=== CONT  TestAccLogsDataProtectionPolicy_basic
=== CONT  TestAccLogsAccountPolicy_disappears
--- PASS: TestAccLogsAccountPolicy_disappears (11.85s)
=== CONT  TestAccLogsAccountPolicy_basicDataProtection
--- PASS: TestAccLogsDataProtectionPolicy_basic (19.57s)
=== CONT  TestAccLogsAccountPolicy_selectionCriteria
--- PASS: TestAccLogsAccountPolicy_basicDataProtection (14.39s)
=== CONT  TestAccLogsDataProtectionPolicy_policyDocument
--- PASS: TestAccLogsAccountPolicy_basicSubscriptionFilter (30.69s)
=== CONT  TestAccLogsDestinationPolicy_basic
--- PASS: TestAccLogsAccountPolicy_selectionCriteria (28.59s)
=== CONT  TestAccLogsDataProtectionPolicy_disappears
--- PASS: TestAccLogsDataProtectionPolicy_policyDocument (29.21s)
--- PASS: TestAccLogsDataProtectionPolicy_disappears (17.00s)
--- PASS: TestAccLogsDestinationPolicy_basic (67.22s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/logs	103.730s

% make testacc TESTARGS='-run=TestAccLogsDestination_' PKG=logs ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/logs/... -v -count 1 -parallel 3  -run=TestAccLogsDestination_ -timeout 360m
2024/12/20 14:09:12 Initializing Terraform AWS Provider...
=== RUN   TestAccLogsDestination_tags
=== PAUSE TestAccLogsDestination_tags
=== RUN   TestAccLogsDestination_tags_null
=== PAUSE TestAccLogsDestination_tags_null
=== RUN   TestAccLogsDestination_tags_EmptyMap
=== PAUSE TestAccLogsDestination_tags_EmptyMap
=== RUN   TestAccLogsDestination_tags_AddOnUpdate
=== PAUSE TestAccLogsDestination_tags_AddOnUpdate
=== RUN   TestAccLogsDestination_tags_EmptyTag_OnCreate
=== PAUSE TestAccLogsDestination_tags_EmptyTag_OnCreate
=== RUN   TestAccLogsDestination_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccLogsDestination_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccLogsDestination_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccLogsDestination_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccLogsDestination_tags_DefaultTags_providerOnly
=== PAUSE TestAccLogsDestination_tags_DefaultTags_providerOnly
=== RUN   TestAccLogsDestination_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccLogsDestination_tags_DefaultTags_nonOverlapping
=== RUN   TestAccLogsDestination_tags_DefaultTags_overlapping
=== PAUSE TestAccLogsDestination_tags_DefaultTags_overlapping
=== RUN   TestAccLogsDestination_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccLogsDestination_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccLogsDestination_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccLogsDestination_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccLogsDestination_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccLogsDestination_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccLogsDestination_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccLogsDestination_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccLogsDestination_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccLogsDestination_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccLogsDestination_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccLogsDestination_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccLogsDestination_tags_ComputedTag_OnCreate
=== PAUSE TestAccLogsDestination_tags_ComputedTag_OnCreate
=== RUN   TestAccLogsDestination_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccLogsDestination_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccLogsDestination_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccLogsDestination_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccLogsDestination_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccLogsDestination_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccLogsDestination_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccLogsDestination_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccLogsDestination_basic
=== PAUSE TestAccLogsDestination_basic
=== RUN   TestAccLogsDestination_disappears
=== PAUSE TestAccLogsDestination_disappears
=== RUN   TestAccLogsDestination_update
=== PAUSE TestAccLogsDestination_update
=== CONT  TestAccLogsDestination_tags
=== CONT  TestAccLogsDestination_tags_DefaultTags_emptyResourceTag
=== CONT  TestAccLogsDestination_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccLogsDestination_tags_DefaultTags_emptyResourceTag (59.24s)
=== CONT  TestAccLogsDestination_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccLogsDestination_tags_ComputedTag_OnUpdate_Replace (73.77s)
=== CONT  TestAccLogsDestination_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccLogsDestination_tags (98.09s)
=== CONT  TestAccLogsDestination_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccLogsDestination_tags_EmptyTag_OnUpdate_Replace (69.27s)
=== CONT  TestAccLogsDestination_tags_DefaultTags_overlapping
--- PASS: TestAccLogsDestination_tags_DefaultTags_updateToResourceOnly (69.63s)
=== CONT  TestAccLogsDestination_tags_DefaultTags_nonOverlapping
--- PASS: TestAccLogsDestination_tags_DefaultTags_updateToProviderOnly (68.36s)
=== CONT  TestAccLogsDestination_tags_DefaultTags_providerOnly
--- PASS: TestAccLogsDestination_tags_DefaultTags_overlapping (83.15s)
=== CONT  TestAccLogsDestination_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccLogsDestination_tags_DefaultTags_nonOverlapping (85.16s)
=== CONT  TestAccLogsDestination_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccLogsDestination_tags_DefaultTags_providerOnly (100.72s)
=== CONT  TestAccLogsDestination_tags_ComputedTag_OnCreate
--- PASS: TestAccLogsDestination_tags_DefaultTags_nullNonOverlappingResourceTag (57.79s)
=== CONT  TestAccLogsDestination_tags_AddOnUpdate
--- PASS: TestAccLogsDestination_tags_ComputedTag_OnUpdate_Add (73.05s)
=== CONT  TestAccLogsDestination_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccLogsDestination_tags_ComputedTag_OnCreate (61.34s)
=== CONT  TestAccLogsDestination_tags_EmptyTag_OnCreate
--- PASS: TestAccLogsDestination_tags_AddOnUpdate (68.23s)
=== CONT  TestAccLogsDestination_tags_EmptyMap
--- PASS: TestAccLogsDestination_tags_EmptyTag_OnUpdate_Add (82.15s)
=== CONT  TestAccLogsDestination_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccLogsDestination_tags_EmptyTag_OnCreate (71.00s)
=== CONT  TestAccLogsDestination_basic
--- PASS: TestAccLogsDestination_tags_EmptyMap (62.08s)
=== CONT  TestAccLogsDestination_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccLogsDestination_tags_DefaultTags_emptyProviderOnlyTag (58.63s)
=== CONT  TestAccLogsDestination_update
--- PASS: TestAccLogsDestination_basic (56.39s)
=== CONT  TestAccLogsDestination_disappears
--- PASS: TestAccLogsDestination_tags_DefaultTags_nullOverlappingResourceTag (57.35s)
=== CONT  TestAccLogsDestination_tags_null
--- PASS: TestAccLogsDestination_disappears (54.20s)
=== CONT  TestAccLogsDestination_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccLogsDestination_tags_null (61.23s)
=== CONT  TestAccLogsDestination_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccLogsDestination_update (95.77s)
--- PASS: TestAccLogsDestination_tags_IgnoreTags_Overlap_ResourceTag (79.97s)
--- PASS: TestAccLogsDestination_tags_IgnoreTags_Overlap_DefaultTag (75.09s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/logs	598.747s

% make testacc TESTARGS='-run=TestAccLogsGroup_' PKG=logs ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/logs/... -v -count 1 -parallel 3  -run=TestAccLogsGroup_ -timeout 360m
2024/12/20 15:07:28 Initializing Terraform AWS Provider...
=== RUN   TestAccLogsGroup_basic
=== PAUSE TestAccLogsGroup_basic
=== RUN   TestAccLogsGroup_nameGenerate
=== PAUSE TestAccLogsGroup_nameGenerate
=== RUN   TestAccLogsGroup_namePrefix
=== PAUSE TestAccLogsGroup_namePrefix
=== RUN   TestAccLogsGroup_disappears
=== PAUSE TestAccLogsGroup_disappears
=== RUN   TestAccLogsGroup_kmsKey
=== PAUSE TestAccLogsGroup_kmsKey
=== RUN   TestAccLogsGroup_logGroupClass
=== PAUSE TestAccLogsGroup_logGroupClass
=== RUN   TestAccLogsGroup_retentionPolicy
=== PAUSE TestAccLogsGroup_retentionPolicy
=== RUN   TestAccLogsGroup_multiple
=== PAUSE TestAccLogsGroup_multiple
=== RUN   TestAccLogsGroup_skipDestroy
=== PAUSE TestAccLogsGroup_skipDestroy
=== RUN   TestAccLogsGroup_skipDestroyInconsistentPlan
=== PAUSE TestAccLogsGroup_skipDestroyInconsistentPlan
=== CONT  TestAccLogsGroup_basic
=== CONT  TestAccLogsGroup_logGroupClass
=== CONT  TestAccLogsGroup_disappears
--- PASS: TestAccLogsGroup_logGroupClass (10.82s)
=== CONT  TestAccLogsGroup_skipDestroy
--- PASS: TestAccLogsGroup_disappears (11.47s)
=== CONT  TestAccLogsGroup_skipDestroyInconsistentPlan
--- PASS: TestAccLogsGroup_basic (13.40s)
=== CONT  TestAccLogsGroup_kmsKey
--- PASS: TestAccLogsGroup_skipDestroy (9.32s)
=== CONT  TestAccLogsGroup_multiple
--- PASS: TestAccLogsGroup_skipDestroyInconsistentPlan (15.78s)
=== CONT  TestAccLogsGroup_namePrefix
--- PASS: TestAccLogsGroup_multiple (10.53s)
=== CONT  TestAccLogsGroup_retentionPolicy
--- PASS: TestAccLogsGroup_namePrefix (12.53s)
=== CONT  TestAccLogsGroup_nameGenerate
--- PASS: TestAccLogsGroup_kmsKey (35.26s)
--- PASS: TestAccLogsGroup_nameGenerate (12.51s)
--- PASS: TestAccLogsGroup_retentionPolicy (28.48s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/logs	64.487s

% make testacc TESTARGS='-run=TestAccLogsGroupsDataSource_' PKG=logs ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/logs/... -v -count 1 -parallel 3  -run=TestAccLogsGroupsDataSource_ -timeout 360m
2024/12/20 15:14:44 Initializing Terraform AWS Provider...
=== RUN   TestAccLogsGroupsDataSource_basic
=== PAUSE TestAccLogsGroupsDataSource_basic
=== RUN   TestAccLogsGroupsDataSource_noPrefix
=== PAUSE TestAccLogsGroupsDataSource_noPrefix
=== CONT  TestAccLogsGroupsDataSource_basic
=== CONT  TestAccLogsGroupsDataSource_noPrefix
--- PASS: TestAccLogsGroupsDataSource_noPrefix (11.04s)
--- PASS: TestAccLogsGroupsDataSource_basic (11.12s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/logs	16.468s

% make testacc TESTARGS='-run=TestAccLogsMetricFilter_' PKG=logs ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/logs/... -v -count 1 -parallel 3  -run=TestAccLogsMetricFilter_ -timeout 360m
2024/12/20 15:20:52 Initializing Terraform AWS Provider...
=== RUN   TestAccLogsMetricFilter_basic
=== PAUSE TestAccLogsMetricFilter_basic
=== RUN   TestAccLogsMetricFilter_disappears
=== PAUSE TestAccLogsMetricFilter_disappears
=== RUN   TestAccLogsMetricFilter_Disappears_logGroup
=== PAUSE TestAccLogsMetricFilter_Disappears_logGroup
=== RUN   TestAccLogsMetricFilter_many
=== PAUSE TestAccLogsMetricFilter_many
=== RUN   TestAccLogsMetricFilter_update
=== PAUSE TestAccLogsMetricFilter_update
=== CONT  TestAccLogsMetricFilter_basic
=== CONT  TestAccLogsMetricFilter_many
=== CONT  TestAccLogsMetricFilter_Disappears_logGroup
--- PASS: TestAccLogsMetricFilter_Disappears_logGroup (12.06s)
=== CONT  TestAccLogsMetricFilter_disappears
--- PASS: TestAccLogsMetricFilter_basic (14.11s)
=== CONT  TestAccLogsMetricFilter_update
--- PASS: TestAccLogsMetricFilter_many (22.04s)
--- PASS: TestAccLogsMetricFilter_disappears (11.60s)
--- PASS: TestAccLogsMetricFilter_update (21.57s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/logs	41.077s

% make testacc TESTARGS='-run=TestAccLogsQueryDefinition_' PKG=logs ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/logs/... -v -count 1 -parallel 3  -run=TestAccLogsQueryDefinition_ -timeout 360m
2024/12/20 15:28:08 Initializing Terraform AWS Provider...
=== RUN   TestAccLogsQueryDefinition_basic
=== PAUSE TestAccLogsQueryDefinition_basic
=== RUN   TestAccLogsQueryDefinition_disappears
=== PAUSE TestAccLogsQueryDefinition_disappears
=== RUN   TestAccLogsQueryDefinition_rename
=== PAUSE TestAccLogsQueryDefinition_rename
=== RUN   TestAccLogsQueryDefinition_logGroups
=== PAUSE TestAccLogsQueryDefinition_logGroups
=== CONT  TestAccLogsQueryDefinition_basic
=== CONT  TestAccLogsQueryDefinition_rename
=== CONT  TestAccLogsQueryDefinition_logGroups
--- PASS: TestAccLogsQueryDefinition_basic (13.41s)
=== CONT  TestAccLogsQueryDefinition_disappears
--- PASS: TestAccLogsQueryDefinition_rename (21.09s)
--- PASS: TestAccLogsQueryDefinition_logGroups (22.52s)
--- PASS: TestAccLogsQueryDefinition_disappears (10.67s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/logs	29.487s

% make testacc TESTARGS='-run=TestAccLogsResourcePolicy_' PKG=logs ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/logs/... -v -count 1 -parallel 3  -run=TestAccLogsResourcePolicy_ -timeout 360m
2024/12/20 15:40:08 Initializing Terraform AWS Provider...
=== RUN   TestAccLogsResourcePolicy_basic
=== PAUSE TestAccLogsResourcePolicy_basic
=== RUN   TestAccLogsResourcePolicy_ignoreEquivalent
=== PAUSE TestAccLogsResourcePolicy_ignoreEquivalent
=== CONT  TestAccLogsResourcePolicy_basic
=== CONT  TestAccLogsResourcePolicy_ignoreEquivalent
--- PASS: TestAccLogsResourcePolicy_ignoreEquivalent (16.28s)
--- PASS: TestAccLogsResourcePolicy_basic (24.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/logs	29.676s

% make testacc TESTARGS='-run=TestAccLogsStream_' PKG=logs ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/logs/... -v -count 1 -parallel 3  -run=TestAccLogsStream_ -timeout 360m
2024/12/20 16:04:01 Initializing Terraform AWS Provider...
=== RUN   TestAccLogsStream_basic
=== PAUSE TestAccLogsStream_basic
=== RUN   TestAccLogsStream_disappears
=== PAUSE TestAccLogsStream_disappears
=== RUN   TestAccLogsStream_Disappears_logGroup
=== PAUSE TestAccLogsStream_Disappears_logGroup
=== CONT  TestAccLogsStream_basic
=== CONT  TestAccLogsStream_Disappears_logGroup
=== CONT  TestAccLogsStream_disappears
--- PASS: TestAccLogsStream_Disappears_logGroup (12.41s)
--- PASS: TestAccLogsStream_disappears (12.42s)
--- PASS: TestAccLogsStream_basic (14.09s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/logs	19.423s

% make testacc TESTARGS='-run=TestAccLogsSubscriptionFilter_' PKG=logs ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/logs/... -v -count 1 -parallel 3  -run=TestAccLogsSubscriptionFilter_ -timeout 360m
2024/12/20 16:15:12 Initializing Terraform AWS Provider...
=== RUN   TestAccLogsSubscriptionFilter_basic
=== PAUSE TestAccLogsSubscriptionFilter_basic
=== RUN   TestAccLogsSubscriptionFilter_many
=== PAUSE TestAccLogsSubscriptionFilter_many
=== RUN   TestAccLogsSubscriptionFilter_disappears
=== PAUSE TestAccLogsSubscriptionFilter_disappears
=== RUN   TestAccLogsSubscriptionFilter_Disappears_logGroup
=== PAUSE TestAccLogsSubscriptionFilter_Disappears_logGroup
=== RUN   TestAccLogsSubscriptionFilter_DestinationARN_kinesisDataFirehose
=== PAUSE TestAccLogsSubscriptionFilter_DestinationARN_kinesisDataFirehose
=== RUN   TestAccLogsSubscriptionFilter_DestinationARN_kinesisStream
=== PAUSE TestAccLogsSubscriptionFilter_DestinationARN_kinesisStream
=== RUN   TestAccLogsSubscriptionFilter_distribution
=== PAUSE TestAccLogsSubscriptionFilter_distribution
=== RUN   TestAccLogsSubscriptionFilter_roleARN
=== PAUSE TestAccLogsSubscriptionFilter_roleARN
=== CONT  TestAccLogsSubscriptionFilter_basic
=== CONT  TestAccLogsSubscriptionFilter_DestinationARN_kinesisDataFirehose
=== CONT  TestAccLogsSubscriptionFilter_distribution
--- PASS: TestAccLogsSubscriptionFilter_basic (35.73s)
=== CONT  TestAccLogsSubscriptionFilter_roleARN
--- PASS: TestAccLogsSubscriptionFilter_distribution (38.51s)
=== CONT  TestAccLogsSubscriptionFilter_DestinationARN_kinesisStream
--- PASS: TestAccLogsSubscriptionFilter_DestinationARN_kinesisDataFirehose (84.19s)
=== CONT  TestAccLogsSubscriptionFilter_disappears
--- PASS: TestAccLogsSubscriptionFilter_DestinationARN_kinesisStream (54.95s)
=== CONT  TestAccLogsSubscriptionFilter_Disappears_logGroup
--- PASS: TestAccLogsSubscriptionFilter_roleARN (73.59s)
=== CONT  TestAccLogsSubscriptionFilter_many
--- PASS: TestAccLogsSubscriptionFilter_disappears (27.03s)
--- PASS: TestAccLogsSubscriptionFilter_Disappears_logGroup (24.22s)
--- PASS: TestAccLogsSubscriptionFilter_many (33.90s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/logs	148.636s

% make testacc TESTARGS='-run=TestAccLogsAnomalyDetector_' PKG=logs ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/logs/... -v -count 1 -parallel 3  -run=TestAccLogsAnomalyDetector_ -timeout 360m
2024/12/20 16:44:21 Initializing Terraform AWS Provider...
=== RUN   TestAccLogsAnomalyDetector_tags
=== PAUSE TestAccLogsAnomalyDetector_tags
=== RUN   TestAccLogsAnomalyDetector_tags_null
=== PAUSE TestAccLogsAnomalyDetector_tags_null
=== RUN   TestAccLogsAnomalyDetector_tags_EmptyMap
=== PAUSE TestAccLogsAnomalyDetector_tags_EmptyMap
=== RUN   TestAccLogsAnomalyDetector_tags_AddOnUpdate
=== PAUSE TestAccLogsAnomalyDetector_tags_AddOnUpdate
=== RUN   TestAccLogsAnomalyDetector_tags_EmptyTag_OnCreate
=== PAUSE TestAccLogsAnomalyDetector_tags_EmptyTag_OnCreate
=== RUN   TestAccLogsAnomalyDetector_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccLogsAnomalyDetector_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccLogsAnomalyDetector_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccLogsAnomalyDetector_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccLogsAnomalyDetector_tags_DefaultTags_providerOnly
=== PAUSE TestAccLogsAnomalyDetector_tags_DefaultTags_providerOnly
=== RUN   TestAccLogsAnomalyDetector_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccLogsAnomalyDetector_tags_DefaultTags_nonOverlapping
=== RUN   TestAccLogsAnomalyDetector_tags_DefaultTags_overlapping
=== PAUSE TestAccLogsAnomalyDetector_tags_DefaultTags_overlapping
=== RUN   TestAccLogsAnomalyDetector_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccLogsAnomalyDetector_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccLogsAnomalyDetector_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccLogsAnomalyDetector_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccLogsAnomalyDetector_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccLogsAnomalyDetector_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccLogsAnomalyDetector_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccLogsAnomalyDetector_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccLogsAnomalyDetector_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccLogsAnomalyDetector_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccLogsAnomalyDetector_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccLogsAnomalyDetector_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccLogsAnomalyDetector_tags_ComputedTag_OnCreate
=== PAUSE TestAccLogsAnomalyDetector_tags_ComputedTag_OnCreate
=== RUN   TestAccLogsAnomalyDetector_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccLogsAnomalyDetector_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccLogsAnomalyDetector_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccLogsAnomalyDetector_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccLogsAnomalyDetector_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccLogsAnomalyDetector_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccLogsAnomalyDetector_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccLogsAnomalyDetector_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccLogsAnomalyDetector_basic
=== PAUSE TestAccLogsAnomalyDetector_basic
=== RUN   TestAccLogsAnomalyDetector_update
=== PAUSE TestAccLogsAnomalyDetector_update
=== RUN   TestAccLogsAnomalyDetector_disappears
=== PAUSE TestAccLogsAnomalyDetector_disappears
=== CONT  TestAccLogsAnomalyDetector_tags
=== CONT  TestAccLogsAnomalyDetector_tags_DefaultTags_emptyResourceTag
=== CONT  TestAccLogsAnomalyDetector_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccLogsAnomalyDetector_tags_DefaultTags_emptyResourceTag (16.96s)
=== CONT  TestAccLogsAnomalyDetector_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccLogsAnomalyDetector_tags_ComputedTag_OnUpdate_Replace (30.07s)
=== CONT  TestAccLogsAnomalyDetector_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccLogsAnomalyDetector_tags_DefaultTags_nullNonOverlappingResourceTag (15.49s)
=== CONT  TestAccLogsAnomalyDetector_tags_ComputedTag_OnCreate
--- PASS: TestAccLogsAnomalyDetector_tags_ComputedTag_OnCreate (18.66s)
=== CONT  TestAccLogsAnomalyDetector_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccLogsAnomalyDetector_tags (53.56s)
=== CONT  TestAccLogsAnomalyDetector_basic
--- PASS: TestAccLogsAnomalyDetector_tags_ComputedTag_OnUpdate_Add (28.51s)
=== CONT  TestAccLogsAnomalyDetector_disappears
--- PASS: TestAccLogsAnomalyDetector_tags_DefaultTags_nullOverlappingResourceTag (15.00s)
=== CONT  TestAccLogsAnomalyDetector_update
--- PASS: TestAccLogsAnomalyDetector_basic (13.64s)
=== CONT  TestAccLogsAnomalyDetector_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccLogsAnomalyDetector_disappears (12.37s)
=== CONT  TestAccLogsAnomalyDetector_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccLogsAnomalyDetector_tags_DefaultTags_emptyProviderOnlyTag (14.91s)
=== CONT  TestAccLogsAnomalyDetector_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccLogsAnomalyDetector_update (25.05s)
=== CONT  TestAccLogsAnomalyDetector_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccLogsAnomalyDetector_tags_IgnoreTags_Overlap_ResourceTag (32.78s)
=== CONT  TestAccLogsAnomalyDetector_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccLogsAnomalyDetector_tags_EmptyTag_OnUpdate_Replace (23.81s)
=== CONT  TestAccLogsAnomalyDetector_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccLogsAnomalyDetector_tags_IgnoreTags_Overlap_DefaultTag (31.08s)
=== CONT  TestAccLogsAnomalyDetector_tags_DefaultTags_overlapping
--- PASS: TestAccLogsAnomalyDetector_tags_DefaultTags_updateToResourceOnly (24.35s)
=== CONT  TestAccLogsAnomalyDetector_tags_DefaultTags_nonOverlapping
--- PASS: TestAccLogsAnomalyDetector_tags_DefaultTags_updateToProviderOnly (25.21s)
=== CONT  TestAccLogsAnomalyDetector_tags_DefaultTags_providerOnly
--- PASS: TestAccLogsAnomalyDetector_tags_DefaultTags_overlapping (40.20s)
=== CONT  TestAccLogsAnomalyDetector_tags_AddOnUpdate
--- PASS: TestAccLogsAnomalyDetector_tags_DefaultTags_nonOverlapping (40.71s)
=== CONT  TestAccLogsAnomalyDetector_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccLogsAnomalyDetector_tags_AddOnUpdate (23.98s)
=== CONT  TestAccLogsAnomalyDetector_tags_EmptyTag_OnCreate
--- PASS: TestAccLogsAnomalyDetector_tags_DefaultTags_providerOnly (52.86s)
=== CONT  TestAccLogsAnomalyDetector_tags_EmptyMap
--- PASS: TestAccLogsAnomalyDetector_tags_EmptyTag_OnUpdate_Add (36.00s)
=== CONT  TestAccLogsAnomalyDetector_tags_null
--- PASS: TestAccLogsAnomalyDetector_tags_EmptyTag_OnCreate (26.82s)
--- PASS: TestAccLogsAnomalyDetector_tags_EmptyMap (15.30s)
--- PASS: TestAccLogsAnomalyDetector_tags_null (15.25s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/logs	221.662s

johnsonaj

LGTM 🚀

ewbankkit · 2024-12-23T14:41:45Z

@jcoelho93 Thanks for the contribution 🎉 👏.

jcoelho93 requested a review from a team as a code owner December 17, 2024 11:02

github-actions bot reviewed Dec 17, 2024

View reviewed changes

ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 17, 2024

jcoelho93 changed the title ~~Adds a cloudwatch log group index policy~~ feat: add cloudwatch log group index policy Dec 18, 2024

jcoelho93 force-pushed the f-logs-field-index branch from 7229245 to c07bd18 Compare December 18, 2024 17:38

jcoelho93 added 12 commits December 19, 2024 10:29

Add index policy resource

1fb75ee

Regiter resource to the provider

c40cc6a

Set up tests

bdfed75

Generate docs

f4b183f

Fix policy document parsing

b9ff589

Fix import and docs

5728203

Improve acceptance tests

64634f7

Refactor to use plugin framework

7a633a0

Fix log group name and remove timeouts

340a5e5

Remove tips

b284c64

Fix basic config

d22be84

Format terraform

fc2477b

jcoelho93 force-pushed the f-logs-field-index branch from 06f156c to fc2477b Compare December 19, 2024 10:29

jcoelho93 added 3 commits December 19, 2024 10:38

Delete files

ddd4140

Make function private to package

3994627

Remove extra white line

ec109b6

jcoelho93 and others added 6 commits December 19, 2024 14:19

Add resource documentation

7075c2d

Merge branch 'main' into HEAD

713a8c4

r/aws_cloudwatch_log_index_policy: Tidy up.

707ff74

Add 'TestAccLogsIndexPolicy_update'.

7804b83

Corrections.

810c631

ewbankkit self-assigned this Dec 19, 2024

github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 19, 2024

ewbankkit added 17 commits December 19, 2024 12:20

logs: Generate paginators.

ef8ae8c

Tweak 'findIndexPolicyByLogGroupName'.

e6d64e8

r/aws_cloudwatch_log_account_policy: Tidy up.

94b9b52

r/aws_cloudwatch_log_data_protection_policy: Tidy up.

f667dcb

'TrimLogGroupARNWildcardSuffix' -> 'trimLogGroupARNWildcardSuffix'.

c491d4e

r/aws_cloudwatch_log_destination_policy: Tidy up.

b7c3576

Add and use 'sdkv2.JSONDocumentSchemaRequired' and 'sdkv2.IAMPolicyDo…

3f0098d

…cumentSchemaRequired'.

r/aws_cloudwatch_log_destination: Tidy up.

79d74c2

r/aws_cloudwatch_log_group: Tidy up.

ac43537

d/aws_cloudwatch_log_groups: Tidy up.

2000045

r/aws_cloudwatch_log_metric_filter: Tidy up.

64a7734

r/aws_cloudwatch_query_definition: Tidy up.

75704f9

r/aws_cloudwatch_log_resource_policy: Tidy up.

7fd411f

r/aws_cloudwatch_log_stream: Tidy up.

9699b33

r/aws_cloudwatch_log_subscription_filter: Tidy up.

2669b40

r/aws_cloudwatch_log_anomaly_detector: Tidy up.

e0d5b2d

Fix semgrep 'ci.logs-in-var-name' and 'ci.logs-in-func-name'.

dbed232

ewbankkit approved these changes Dec 20, 2024

View reviewed changes

johnsonaj approved these changes Dec 23, 2024

View reviewed changes

ewbankkit merged commit a1c56f2 into hashicorp:main Dec 23, 2024
42 checks passed

github-actions bot added this to the v5.83.0 milestone Dec 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add cloudwatch log group index policy #40594

feat: add cloudwatch log group index policy #40594

jcoelho93 commented Dec 17, 2024 •

edited

Loading

github-actions bot commented Dec 17, 2024

github-actions bot left a comment

jar-b commented Dec 18, 2024

jcoelho93 commented Dec 18, 2024

ewbankkit left a comment

johnsonaj left a comment

ewbankkit commented Dec 23, 2024

feat: add cloudwatch log group index policy #40594

feat: add cloudwatch log group index policy #40594

Conversation

jcoelho93 commented Dec 17, 2024 • edited Loading

Description

Relations

References

Output from Acceptance Testing

github-actions bot commented Dec 17, 2024

Community Note

github-actions bot left a comment

Choose a reason for hiding this comment

jar-b commented Dec 18, 2024

jcoelho93 commented Dec 18, 2024

ewbankkit left a comment

Choose a reason for hiding this comment

johnsonaj left a comment

Choose a reason for hiding this comment

ewbankkit commented Dec 23, 2024

jcoelho93 commented Dec 17, 2024 •

edited

Loading