Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new sesv2 attributes #40194

Merged
merged 9 commits into from
Dec 12, 2024
Merged

Add new sesv2 attributes #40194

merged 9 commits into from
Dec 12, 2024

Conversation

lvthillo
Copy link
Contributor

Description

Add 2 new attributes

Relations

Closes #40170

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccSESV2ConfigurationSet_deliveryOptions PKG=sesv2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/sesv2/... -v -count 1 -parallel 20 -run='TestAccSESV2ConfigurationSet_deliveryOptions'  -timeout 360m
2024/11/19 20:40:05 Initializing Terraform AWS Provider...
=== RUN   TestAccSESV2ConfigurationSet_deliveryOptions
=== PAUSE TestAccSESV2ConfigurationSet_deliveryOptions
=== CONT  TestAccSESV2ConfigurationSet_deliveryOptions
--- PASS: TestAccSESV2ConfigurationSet_deliveryOptions (31.70s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sesv2      47.642s


$ make testacc TESTS=TestAccSESV2ConfigurationSetDataSource_basic PKG=sesv2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/sesv2/... -v -count 1 -parallel 20 -run='TestAccSESV2ConfigurationSetDataSource_basic'  -timeout 360m
2024/11/19 20:38:35 Initializing Terraform AWS Provider...
=== RUN   TestAccSESV2ConfigurationSetDataSource_basic
=== PAUSE TestAccSESV2ConfigurationSetDataSource_basic
=== CONT  TestAccSESV2ConfigurationSetDataSource_basic
--- PASS: TestAccSESV2ConfigurationSetDataSource_basic (17.14s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sesv2      31.649s
...

Remark: No test added for the new https_policy. This requires a custom_redirect_domain which requires a verified domain.

@lvthillo lvthillo requested a review from a team as a code owner November 19, 2024 19:41
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/sesv2 Issues and PRs that pertain to the sesv2 service. needs-triage Waiting for first response or review from a maintainer. labels Nov 19, 2024
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 19, 2024
@pas256
Copy link

pas256 commented Dec 9, 2024

Thank you for adding this PR. I have been doing this via the console.

pas256
pas256 approved these changes Dec 9, 2024
View reviewed changes
Copy link

@pas256 pas256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ewbankkit ewbankkit self-assigned this Dec 12, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 12, 2024
ewbankkit
ewbankkit approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSESV2ConfigurationSet_\|TestAccSESV2ConfigurationSetDataSource_' PKG=sesv2 ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/sesv2/... -v -count 1 -parallel 4  -run=TestAccSESV2ConfigurationSet_\|TestAccSESV2ConfigurationSetDataSource_ -timeout 360m
2024/12/12 10:36:34 Initializing Terraform AWS Provider...
=== RUN   TestAccSESV2ConfigurationSetDataSource_tags
=== PAUSE TestAccSESV2ConfigurationSetDataSource_tags
=== RUN   TestAccSESV2ConfigurationSetDataSource_tags_NullMap
=== PAUSE TestAccSESV2ConfigurationSetDataSource_tags_NullMap
=== RUN   TestAccSESV2ConfigurationSetDataSource_tags_EmptyMap
=== PAUSE TestAccSESV2ConfigurationSetDataSource_tags_EmptyMap
=== RUN   TestAccSESV2ConfigurationSetDataSource_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccSESV2ConfigurationSetDataSource_tags_DefaultTags_nonOverlapping
=== RUN   TestAccSESV2ConfigurationSetDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccSESV2ConfigurationSetDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccSESV2ConfigurationSetDataSource_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccSESV2ConfigurationSetDataSource_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccSESV2ConfigurationSetDataSource_basic
=== PAUSE TestAccSESV2ConfigurationSetDataSource_basic
=== RUN   TestAccSESV2ConfigurationSet_tags
=== PAUSE TestAccSESV2ConfigurationSet_tags
=== RUN   TestAccSESV2ConfigurationSet_tags_null
=== PAUSE TestAccSESV2ConfigurationSet_tags_null
=== RUN   TestAccSESV2ConfigurationSet_tags_EmptyMap
=== PAUSE TestAccSESV2ConfigurationSet_tags_EmptyMap
=== RUN   TestAccSESV2ConfigurationSet_tags_AddOnUpdate
=== PAUSE TestAccSESV2ConfigurationSet_tags_AddOnUpdate
=== RUN   TestAccSESV2ConfigurationSet_tags_EmptyTag_OnCreate
=== PAUSE TestAccSESV2ConfigurationSet_tags_EmptyTag_OnCreate
=== RUN   TestAccSESV2ConfigurationSet_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccSESV2ConfigurationSet_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccSESV2ConfigurationSet_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccSESV2ConfigurationSet_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccSESV2ConfigurationSet_tags_DefaultTags_providerOnly
=== PAUSE TestAccSESV2ConfigurationSet_tags_DefaultTags_providerOnly
=== RUN   TestAccSESV2ConfigurationSet_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccSESV2ConfigurationSet_tags_DefaultTags_nonOverlapping
=== RUN   TestAccSESV2ConfigurationSet_tags_DefaultTags_overlapping
=== PAUSE TestAccSESV2ConfigurationSet_tags_DefaultTags_overlapping
=== RUN   TestAccSESV2ConfigurationSet_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccSESV2ConfigurationSet_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccSESV2ConfigurationSet_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccSESV2ConfigurationSet_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccSESV2ConfigurationSet_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccSESV2ConfigurationSet_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccSESV2ConfigurationSet_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccSESV2ConfigurationSet_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccSESV2ConfigurationSet_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccSESV2ConfigurationSet_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccSESV2ConfigurationSet_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccSESV2ConfigurationSet_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccSESV2ConfigurationSet_tags_ComputedTag_OnCreate
=== PAUSE TestAccSESV2ConfigurationSet_tags_ComputedTag_OnCreate
=== RUN   TestAccSESV2ConfigurationSet_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccSESV2ConfigurationSet_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccSESV2ConfigurationSet_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccSESV2ConfigurationSet_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccSESV2ConfigurationSet_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccSESV2ConfigurationSet_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccSESV2ConfigurationSet_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccSESV2ConfigurationSet_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccSESV2ConfigurationSet_basic
=== PAUSE TestAccSESV2ConfigurationSet_basic
=== RUN   TestAccSESV2ConfigurationSet_disappears
=== PAUSE TestAccSESV2ConfigurationSet_disappears
=== RUN   TestAccSESV2ConfigurationSet_deliveryOptions
=== PAUSE TestAccSESV2ConfigurationSet_deliveryOptions
=== RUN   TestAccSESV2ConfigurationSet_reputationMetricsEnabled
=== PAUSE TestAccSESV2ConfigurationSet_reputationMetricsEnabled
=== RUN   TestAccSESV2ConfigurationSet_sendingEnabled
=== PAUSE TestAccSESV2ConfigurationSet_sendingEnabled
=== RUN   TestAccSESV2ConfigurationSet_suppressedReasons
=== PAUSE TestAccSESV2ConfigurationSet_suppressedReasons
=== RUN   TestAccSESV2ConfigurationSet_suppressedReasonsEmpty
=== PAUSE TestAccSESV2ConfigurationSet_suppressedReasonsEmpty
=== RUN   TestAccSESV2ConfigurationSet_engagementMetrics
=== PAUSE TestAccSESV2ConfigurationSet_engagementMetrics
=== RUN   TestAccSESV2ConfigurationSet_optimizedSharedDelivery
=== PAUSE TestAccSESV2ConfigurationSet_optimizedSharedDelivery
=== CONT  TestAccSESV2ConfigurationSetDataSource_tags
=== CONT  TestAccSESV2ConfigurationSet_tags_DefaultTags_emptyResourceTag
=== CONT  TestAccSESV2ConfigurationSet_tags_AddOnUpdate
=== CONT  TestAccSESV2ConfigurationSetDataSource_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccSESV2ConfigurationSetDataSource_tags (11.91s)
=== CONT  TestAccSESV2ConfigurationSetDataSource_tags_DefaultTags_nonOverlapping
--- PASS: TestAccSESV2ConfigurationSetDataSource_tags_IgnoreTags_Overlap_ResourceTag (12.76s)
=== CONT  TestAccSESV2ConfigurationSetDataSource_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccSESV2ConfigurationSet_tags_DefaultTags_emptyResourceTag (14.96s)
=== CONT  TestAccSESV2ConfigurationSet_basic
--- PASS: TestAccSESV2ConfigurationSetDataSource_tags_DefaultTags_nonOverlapping (10.94s)
=== CONT  TestAccSESV2ConfigurationSet_optimizedSharedDelivery
--- PASS: TestAccSESV2ConfigurationSet_tags_AddOnUpdate (23.33s)
=== CONT  TestAccSESV2ConfigurationSet_engagementMetrics
--- PASS: TestAccSESV2ConfigurationSetDataSource_tags_IgnoreTags_Overlap_DefaultTag (10.65s)
=== CONT  TestAccSESV2ConfigurationSet_suppressedReasonsEmpty
--- PASS: TestAccSESV2ConfigurationSet_basic (12.54s)
=== CONT  TestAccSESV2ConfigurationSet_suppressedReasons
--- PASS: TestAccSESV2ConfigurationSet_suppressedReasonsEmpty (12.34s)
=== CONT  TestAccSESV2ConfigurationSet_sendingEnabled
--- PASS: TestAccSESV2ConfigurationSet_optimizedSharedDelivery (19.95s)
=== CONT  TestAccSESV2ConfigurationSet_reputationMetricsEnabled
--- PASS: TestAccSESV2ConfigurationSet_engagementMetrics (19.66s)
=== CONT  TestAccSESV2ConfigurationSet_deliveryOptions
--- PASS: TestAccSESV2ConfigurationSet_suppressedReasons (20.06s)
=== CONT  TestAccSESV2ConfigurationSet_disappears
--- PASS: TestAccSESV2ConfigurationSet_sendingEnabled (19.84s)
=== CONT  TestAccSESV2ConfigurationSet_tags_EmptyMap
--- PASS: TestAccSESV2ConfigurationSet_disappears (10.28s)
=== CONT  TestAccSESV2ConfigurationSet_tags
--- PASS: TestAccSESV2ConfigurationSet_reputationMetricsEnabled (19.89s)
=== CONT  TestAccSESV2ConfigurationSet_tags_null
--- PASS: TestAccSESV2ConfigurationSet_deliveryOptions (19.87s)
=== CONT  TestAccSESV2ConfigurationSet_tags_DefaultTags_nonOverlapping
--- PASS: TestAccSESV2ConfigurationSet_tags_EmptyMap (16.92s)
=== CONT  TestAccSESV2ConfigurationSet_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccSESV2ConfigurationSet_tags_null (16.71s)
=== CONT  TestAccSESV2ConfigurationSetDataSource_tags_EmptyMap
--- PASS: TestAccSESV2ConfigurationSetDataSource_tags_EmptyMap (10.27s)
=== CONT  TestAccSESV2ConfigurationSet_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccSESV2ConfigurationSet_tags_DefaultTags_updateToResourceOnly (20.82s)
=== CONT  TestAccSESV2ConfigurationSet_tags_DefaultTags_overlapping
--- PASS: TestAccSESV2ConfigurationSet_tags_DefaultTags_nonOverlapping (36.55s)
=== CONT  TestAccSESV2ConfigurationSet_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccSESV2ConfigurationSet_tags (46.72s)
=== CONT  TestAccSESV2ConfigurationSet_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccSESV2ConfigurationSet_tags_DefaultTags_updateToProviderOnly (22.27s)
=== CONT  TestAccSESV2ConfigurationSet_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccSESV2ConfigurationSet_tags_ComputedTag_OnUpdate_Add (26.25s)
=== CONT  TestAccSESV2ConfigurationSetDataSource_tags_NullMap
--- PASS: TestAccSESV2ConfigurationSet_tags_DefaultTags_overlapping (37.38s)
=== CONT  TestAccSESV2ConfigurationSetDataSource_basic
--- PASS: TestAccSESV2ConfigurationSet_tags_IgnoreTags_Overlap_DefaultTag (27.88s)
=== CONT  TestAccSESV2ConfigurationSet_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccSESV2ConfigurationSetDataSource_tags_NullMap (10.63s)
=== CONT  TestAccSESV2ConfigurationSet_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccSESV2ConfigurationSetDataSource_basic (10.81s)
=== CONT  TestAccSESV2ConfigurationSet_tags_DefaultTags_providerOnly
--- PASS: TestAccSESV2ConfigurationSet_tags_IgnoreTags_Overlap_ResourceTag (32.67s)
=== CONT  TestAccSESV2ConfigurationSet_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccSESV2ConfigurationSet_tags_DefaultTags_nullNonOverlappingResourceTag (13.48s)
=== CONT  TestAccSESV2ConfigurationSet_tags_ComputedTag_OnCreate
--- PASS: TestAccSESV2ConfigurationSet_tags_ComputedTag_OnUpdate_Replace (25.92s)
=== CONT  TestAccSESV2ConfigurationSet_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccSESV2ConfigurationSet_tags_EmptyTag_OnUpdate_Replace (22.32s)
=== CONT  TestAccSESV2ConfigurationSet_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccSESV2ConfigurationSet_tags_DefaultTags_nullOverlappingResourceTag (13.90s)
=== CONT  TestAccSESV2ConfigurationSet_tags_EmptyTag_OnCreate
--- PASS: TestAccSESV2ConfigurationSet_tags_ComputedTag_OnCreate (17.09s)
=== CONT  TestAccSESV2ConfigurationSet_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccSESV2ConfigurationSet_tags_DefaultTags_emptyProviderOnlyTag (14.08s)
--- PASS: TestAccSESV2ConfigurationSet_tags_DefaultTags_providerOnly (48.24s)
--- PASS: TestAccSESV2ConfigurationSet_tags_EmptyTag_OnUpdate_Add (33.44s)
--- PASS: TestAccSESV2ConfigurationSet_tags_EmptyTag_OnCreate (24.53s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sesv2	202.281s

jar-b
jar-b approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit
Copy link
Contributor

@lvthillo Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 3d1a719 into hashicorp:main Dec 12, 2024
48 checks passed
@github-actions github-actions bot added this to the v5.81.0 milestone Dec 12, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 12, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.81.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jar-b jar-b jar-b approved these changes

@ewbankkit ewbankkit ewbankkit approved these changes

@pas256 pas256 pas256 approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/sesv2 Issues and PRs that pertain to the sesv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.81.0
Development

Successfully merging this pull request may close these issues.

[New]: aws_sesv2_configuration_set is missing HttpsPolicy and MaxDeliverySeconds
5 participants
@lvthillo @pas256 @ewbankkit @jar-b @justinretzolk