-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update route53 import command #39628
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @nimboya 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
Hey @nimboya 👋 Thank you for taking the time to raise this! I'm not certain I follow this change. Can you provide a bit more information as to why you feel this is a necessary change? |
Hello @justinretzolk, The command to import Route53 DNS record was wrong. It does not need the Domain and Record type. When I used it that way it did not import the resource correctly to the Terraform state. The correct command was without the Domain/Sub-domain and record type. It should be this
and not this
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
@nimboya Thanks for the contribution 🎉 👏. |
Description
Relations
Closes #0000
References
Output from Acceptance Testing