Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update route53 import command #39628

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

nimboya
Copy link
Contributor

@nimboya nimboya commented Oct 8, 2024

Description

Relations

Closes #0000

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

@nimboya nimboya requested a review from a team as a code owner October 8, 2024 17:23
Copy link

github-actions bot commented Oct 8, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/route53 Issues and PRs that pertain to the route53 service. needs-triage Waiting for first response or review from a maintainer. labels Oct 8, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @nimboya 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk
Copy link
Member

Hey @nimboya 👋 Thank you for taking the time to raise this! I'm not certain I follow this change. Can you provide a bit more information as to why you feel this is a necessary change?

@justinretzolk justinretzolk added the waiting-response Maintainers are waiting on response from community or contributor. label Oct 11, 2024
@nimboya
Copy link
Contributor Author

nimboya commented Oct 15, 2024

Hey @nimboya 👋 Thank you for taking the time to raise this! I'm not certain I follow this change. Can you provide a bit more information as to why you feel this is a necessary change?

Hello @justinretzolk,

The command to import Route53 DNS record was wrong. It does not need the Domain and Record type. When I used it that way it did not import the resource correctly to the Terraform state. The correct command was without the Domain/Sub-domain and record type.

It should be this

terraform import aws_route53_record.myrecord Z4KAPRWWNC7JR_dev_NS_dev

and not this

terraform import aws_route53_record.myrecord Z4KAPRWWNC7JR_dev.example.com_NS

@github-actions github-actions bot removed the waiting-response Maintainers are waiting on response from community or contributor. label Oct 15, 2024
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Oct 21, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@nimboya Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 97d06a8 into hashicorp:main Dec 23, 2024
16 checks passed
@github-actions github-actions bot added this to the v5.83.0 milestone Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. service/route53 Issues and PRs that pertain to the route53 service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants