Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

td/auto-flex-union-type_aws_appfabric_ingestion_destination #39552

Conversation

GlennChia
Copy link
Collaborator

Description

Add auto flex for union types in a resource that existed before the feature was released.

Relations

References

Output from Acceptance Testing

Requesting help to run the test cases since this requires AWS_APPFABRIC_TERRAFORMCLOUD_TENANT_ID to be set

% make testacc TESTARGS='-run=TestAccAppFabric_serial/IngestionDestination' PKG=appfabric ACCTEST_PARALLELISM=1

...

@GlennChia GlennChia requested a review from a team as a code owner October 1, 2024 15:22
Copy link

github-actions bot commented Oct 1, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/appfabric Issues and PRs that pertain to the appfabric service. needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Oct 1, 2024
@jar-b jar-b removed the needs-triage Waiting for first response or review from a maintainer. label Oct 1, 2024
@GlennChia GlennChia force-pushed the td-appfabric_ingestion_destination-autoflex branch from 1ffabd6 to 6b3cc9f Compare October 1, 2024 16:00
@ewbankkit ewbankkit added technical-debt Addresses areas of the codebase that need refactoring or redesign. autoflex Pertains to AutoFlex. labels Oct 1, 2024
@ewbankkit ewbankkit self-assigned this Oct 1, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 1, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% AWS_DEFAULT_REGION=us-east-1 AWS_APPFABRIC_TERRAFORMCLOUD_TENANT_ID=... AWS_APPFABRIC_TERRAFORMCLOUD_SERVICE_ACCOUNT_TOKEN=... make testacc TESTARGS='-run=TestAccAppFabric_serial/IngestionDestination' PKG=appfabric
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/appfabric/... -v -count 1 -parallel 20  -run=TestAccAppFabric_serial/IngestionDestination -timeout 360m
=== RUN   TestAccAppFabric_serial
=== PAUSE TestAccAppFabric_serial
=== CONT  TestAccAppFabric_serial
=== RUN   TestAccAppFabric_serial/IngestionDestination
=== RUN   TestAccAppFabric_serial/IngestionDestination/basic
=== RUN   TestAccAppFabric_serial/IngestionDestination/disappears
=== RUN   TestAccAppFabric_serial/IngestionDestination/tags
=== RUN   TestAccAppFabric_serial/IngestionDestination/update
=== RUN   TestAccAppFabric_serial/IngestionDestination/firehose
--- PASS: TestAccAppFabric_serial (184.53s)
    --- PASS: TestAccAppFabric_serial/IngestionDestination (184.53s)
        --- PASS: TestAccAppFabric_serial/IngestionDestination/basic (22.50s)
        --- PASS: TestAccAppFabric_serial/IngestionDestination/disappears (20.30s)
        --- PASS: TestAccAppFabric_serial/IngestionDestination/tags (35.30s)
        --- PASS: TestAccAppFabric_serial/IngestionDestination/update (29.20s)
        --- PASS: TestAccAppFabric_serial/IngestionDestination/firehose (77.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appfabric	190.079s

@ewbankkit
Copy link
Contributor

@GlennChia Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit ffafe9f into hashicorp:main Oct 1, 2024
30 checks passed
@github-actions github-actions bot added this to the v5.70.0 milestone Oct 1, 2024
Copy link

github-actions bot commented Oct 4, 2024

This functionality has been released in v5.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 4, 2024
Copy link

github-actions bot commented Nov 4, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autoflex Pertains to AutoFlex. partner Contribution from a partner. service/appfabric Issues and PRs that pertain to the appfabric service. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants