Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_route53profiles_profile #37124

Conversation

rubenandre
Copy link
Contributor

@rubenandre rubenandre commented Apr 26, 2024

Description

Implementation of resource aws_route53profiles_profile

Relations

Closes #37050

References

Output from Acceptance Testing

Tests applied to all PKG since it's the first resource

% make testacc PKG=route53profiles
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/route53profiles/... -v -count 1 -parallel 20   -timeout 360m
=== RUN   TestAccRoute53ProfilesProfile_basic
=== PAUSE TestAccRoute53ProfilesProfile_basic
=== RUN   TestAccRoute53ProfilesProfile_disappears
=== PAUSE TestAccRoute53ProfilesProfile_disappears
=== RUN   TestAccRoute53ProfilesProfile_tags
=== PAUSE TestAccRoute53ProfilesProfile_tags
=== CONT  TestAccRoute53ProfilesProfile_basic
=== CONT  TestAccRoute53ProfilesProfile_tags
=== CONT  TestAccRoute53ProfilesProfile_disappears
--- PASS: TestAccRoute53ProfilesProfile_disappears (9.29s)
--- PASS: TestAccRoute53ProfilesProfile_basic (11.00s)
--- PASS: TestAccRoute53ProfilesProfile_tags (22.45s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53profiles    24.923s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/route53profiles Issues and PRs that pertain to the route53profiles service. labels Apr 26, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 26, 2024
@justinretzolk justinretzolk added new-service Introduces a new service. new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. new-service Introduces a new service. labels Apr 26, 2024
@rubenandre rubenandre marked this pull request as ready for review April 26, 2024 19:56
@github-actions github-actions bot added the tags Pertains to resource tagging. label May 12, 2024
@alexjfisher
Copy link

Hi! Really looking forward to this making it in. @justinretzolk is there a rough time-frame for incorporating this feature? Thanks.

@Pacobart
Copy link

@justinretzolk Can we get an update on releasing this feature? We are waiting on its availability.

@ewbankkit
Copy link
Contributor

This functionality has been included in #38172.
@rubenandre Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit closed this Oct 8, 2024
Copy link

github-actions bot commented Nov 8, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/route53profiles Issues and PRs that pertain to the route53profiles service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Service]: Route53 Profiles
5 participants