Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Add optional parameter for unauthenticated metrics access #267

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vgsantoniazzi
Copy link

Description

There's no way to generate unauthenticated metrics access. I've tried to use the merge config files but it seems that the "tcp" listener got overridden by the second file.

Open issue: hashicorp/vault#5860

Documentation

TODOs

Please ensure all of these TODOs are completed before asking for a review.

  • Ensure the branch is named correctly with the issue number. e.g: feature/new-vpc-endpoints-955 or bug/missing-count-param-434.
  • Update the docs.
  • Keep the changes backward compatible where possible.
  • Run the pre-commit checks successfully.
  • Run the relevant tests successfully.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.

Related Issues

@hashicorp-cla
Copy link

hashicorp-cla commented Apr 27, 2022

CLA assistant check
All committers have signed the CLA.

@TomGudman
Copy link

Cool! Exactly what were going to do! Thank you!

@rcousens
Copy link

Would love to see this merged as it is the last stumbling block in automating our metrics setup for vault!

@vgsantoniazzi
Copy link
Author

@rcousens replaced the underscore with hyphens. Does it look good now?

@vgsantoniazzi
Copy link
Author

@robmorgan can you take a look?

Copy link

@rcousens rcousens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

modules/run-vault/run-vault Outdated Show resolved Hide resolved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants