Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Add testing for Ubuntu 20.04 #247

Closed
wants to merge 6 commits into from
Closed

Add testing for Ubuntu 20.04 #247

wants to merge 6 commits into from

Conversation

yorinasub17
Copy link
Contributor

This updates the tests to run against Ubuntu 20.04. In the process, I went through and updated all usage of python to python3.

NOTE: I don't have write access to this repo, so I have to push the PR on a fork. This means that automated tests won't be triggered automatically, so would appreciate if someone with write access can do the testpr call to kickoff the testing.

@yorinasub17 yorinasub17 requested a review from robmorgan as a code owner June 10, 2021 16:33
@yorinasub17
Copy link
Contributor Author

Ah just realized this would depend on #243, so we should get that merged first.

@yorinasub17 yorinasub17 reopened this Jun 30, 2021
@yorinasub17
Copy link
Contributor Author

@brikis98 This is now ready for testing. I pulled in the commits directly from #243 via cherrypicking.

Copy link
Collaborator

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM! Just minor comments. I'll kick off tests now.

@yorinasub17
Copy link
Contributor Author

@brikis98 ready for another round of testing when you get the chance.

Copy link
Collaborator

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll kick off tests now.

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 12, 2022

CLA assistant check
All committers have signed the CLA.

@yorinasub17
Copy link
Contributor Author

Closing as outdated

@yorinasub17 yorinasub17 closed this Aug 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants