wip: remove netlog

nvml/client.go

@@ -7,8 +7,6 @@ import (
 	"cmp"
 	"fmt"
 	"slices"
-
-	"github.com/shoenig/netlog"
 )
 
 // DeviceData represents common fields for Nvidia device
@@ -81,8 +79,6 @@ func NewNvmlClient() (*nvmlClient, error) {
 	}, nil
 }
 
-var nl = netlog.New("nvml")
-
 // GetFingerprintData returns FingerprintData for available Nvidia devices
 func (c *nvmlClient) GetFingerprintData() (*FingerprintData, error) {
 	/*
@@ -117,8 +113,6 @@ func (c *nvmlClient) GetFingerprintData() (*FingerprintData, error) {
 	allNvidiaGPUResources := make([]*FingerprintDeviceData, 0, len(deviceUUIDs))
 
 	for uuid, mode := range deviceUUIDs {
-		nl.Info("GFP", "uuid", uuid, "mode", mode)
-
 		// do not care about phsyical parents of MIGs
 		if mode == parent {
 			continue
@@ -197,7 +191,6 @@ func (c *nvmlClient) GetStatsData() ([]*StatsData, error) {
 
 		deviceInfo, deviceStatus, err := c.driver.DeviceInfoAndStatusByUUID(uuid)
 		if err != nil {
-			nl.Error("A DeviceInfoAndStatusByUUID failed", "uuid", uuid, "mode", mode)
 			return nil, fmt.Errorf("nvidia nvml DeviceInfoAndStatusByUUID() error: %v\n", err)
 		}
 

nvml/client_test.go

@@ -11,6 +11,8 @@ import (
 	"github.com/shoenig/test/must"
 )
 
+var _ NvmlDriver = (*MockNVMLDriver)(nil)
+
 type MockNVMLDriver struct {
 	systemDriverCallSuccessful              bool
 	listDeviceUUIDsSuccessful               bool
@@ -36,15 +38,15 @@ func (m *MockNVMLDriver) SystemDriverVersion() (string, error) {
 	return m.driverVersion, nil
 }
 
-func (m *MockNVMLDriver) ListDeviceUUIDs() ([]string, error) {
+func (m *MockNVMLDriver) ListDeviceUUIDs() (map[string]mode, error) {
 	if !m.listDeviceUUIDsSuccessful {
 		return nil, errors.New("failed to get device length")
 	}
 
-	allNvidiaGPUUUIDs := make([]string, len(m.devices))
+	allNvidiaGPUUUIDs := make(map[string]mode)
 
-	for i, device := range m.devices {
-		allNvidiaGPUUUIDs[i] = device.UUID
+	for _, device := range m.devices {
+		allNvidiaGPUUUIDs[device.UUID] = normal
 	}
 
 	return allNvidiaGPUUUIDs, nil