Allow errors from CheckRetry to be logged #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With HTTP requests, there are requests which "succeed" in terms of the HTTP standard, but are failures for a "normal" client. For example, 503 status returns. With the DefaultCheckRetry, 503 errors *are* set to be retried, but since the request itself completed without error, this "error" isn't communicated to the user at all. So to the user, it can seem like code is hanging, when in reality, it's doing the "correct" backoffs and retries. This change therefore will additionally print the error logs if `checkErr` is non-nil
|
|
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With HTTP requests, there are requests which "succeed" in terms of the HTTP standard, but are failures for a "normal" client. For example, 503 status returns.
With the DefaultCheckRetry, 503 errors are set to be retried, but since the request itself completed without error, this "error" isn't communicated to the user at all. So to the user, it can seem like code is hanging, when in reality, it's doing the "correct" backoffs and retries.
This change therefore will additionally print the error logs if
checkErris non-nil