logs: redact in URL passwords #133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So if we have URL like this one http://user:[email protected]/ the password is not logged
|
|
|
the If you are interested in merging this patch and at the same time you want to keep compatibility with older Go versions I could add a local method to redact the passwords instead of using URL.Redacted, thank you |
drakkan
added a commit
to drakkan/sftpgo
that referenced
this pull request
May 12, 2021
go-retryablehttp does not redact credentials, so we still log them when we use it hashicorp/go-retryablehttp#133
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So if we have URL like this one http://user:[email protected]/ the password is not logged