Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix for vault/docs/commands #2636

Closed
wants to merge 1 commit into from
Closed

Conversation

zchsh
Copy link
Contributor

@zchsh zchsh commented Nov 22, 2024

Warning

We likely don't want to merge this PR, and instead should merge a content fix. Content fix in progress:

🔗 Relevant links

🗒️ What

This PR introduces a very band-aid-ish hot-fix for a content extraction issue upstream.

🤷 Why

Currently production builds are failing, we want to figure out why, hopefully this PR will help.

🛠️ How

Uses mdxContentHook to patch the issue with the content coming back from content.hashicorp.com just before rendering the MDX.

📸 Design Screenshots

Before After
🚧 🚧

🧪 Testing

🚧 TODO

💭 Anything else?

This PR does not represent the recommended approach to fix this issue. Fixing the issue at the content source, to avoid malformed content being extracted into our content.hashicorp.com API, is highly preferable.

Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-portal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 5:13pm

Copy link

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

This PR introduced no changes to the javascript bundle 🙌

@RubenSandwich
Copy link
Collaborator

Closing so it doesn't get accidentally shipped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants