Merge pull request #1627 from hashicorp/melsumner/update-pagination-a…

…ria-label Update aria-label for pagination nav element
hashicorp · Sep 19, 2023 · a6573ef · a6573ef · vercel · Sep 19, 2023
2 parents a0d4c9f + 53c9f13
commit a6573ef
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 6 deletions.
diff --git a/.changeset/perfect-pens-cry.md b/.changeset/perfect-pens-cry.md
@@ -0,0 +1,5 @@
+---
+"@hashicorp/design-system-components": patch
+---
+
+Bugfix aria-label on pagination component
diff --git a/packages/components/addon/components/hds/pagination/compact/index.js b/packages/components/addon/components/hds/pagination/compact/index.js
@@ -50,10 +50,10 @@ export default class HdsPaginationCompactIndexComponent extends Component {
   /**
    * @param ariaLabel
    * @type {string}
-   * @default 'Pagination navigation'
+   * @default 'Pagination'
    */
   get ariaLabel() {
-    return this.args.ariaLabel ?? 'Pagination navigation';
+    return this.args.ariaLabel ?? 'Pagination';
   }
 
   get routeQueryParams() {

diff --git a/packages/components/addon/components/hds/pagination/numbered/index.js b/packages/components/addon/components/hds/pagination/numbered/index.js
@@ -130,10 +130,10 @@ export default class HdsPaginationNumberedIndexComponent extends Component {
   /**
    * @param ariaLabel
    * @type {string}
-   * @default 'Pagination navigation'
+   * @default 'Pagination'
    */
   get ariaLabel() {
-    return this.args.ariaLabel ?? 'Pagination navigation';
+    return this.args.ariaLabel ?? 'Pagination';
   }
 
   // This very specific `get/set` pattern is used to handle the two different use cases of the component

diff --git a/website/docs/components/pagination/partials/code/component-api.md b/website/docs/components/pagination/partials/code/component-api.md
@@ -22,7 +22,7 @@ These Pagination sub-elements may be used directly if you need to cover a very s
 ### Pagination::Numbered
 
 <Doc::ComponentApi as |C|>
-<C.Property @name="ariaLabel" @type="string" @default="Pagination navigation">
+<C.Property @name="ariaLabel" @type="string" @default="Pagination">
     Accepts a localized string.
 </C.Property>
 <C.Property @name="totalItems" @required="true" @type="number">
@@ -66,7 +66,7 @@ This component supports use of [`...attributes`](https://guides.emberjs.com/rele
 ### Pagination::Compact
 
 <Doc::ComponentApi as |C|>
-<C.Property @name="ariaLabel" @type="string" @default="Pagination navigation">
+<C.Property @name="ariaLabel" @type="string" @default="Pagination">
     Accepts a localized string.
 </C.Property>
 <C.Property @name="route/model/models/replace">