Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inconsistent failures #866

Merged
merged 14 commits into from
Nov 25, 2024
Merged

Conversation

jeromy-cannon
Copy link
Contributor

@jeromy-cannon jeromy-cannon commented Nov 22, 2024

Description

This pull request changes the following:

  • fixes: Inconsistent successful starts of Solo Inconsistent successful starts of Solo #727
  • updated eslint config to throw errors on no-invalid-this and split out test from other source
  • update npm run build to also delete the ./dist directory prior to tsc build
  • updated post-build-script.js to include recursive chmod for when npm link is leveraged on developers machine
  • added --stake-amounts flag to solo node start so that we can stake specific amounts and drop the required nodes deployed for solo node delete down to 2 nodes
  • made logging more readible
  • fixed issue where sometimes platform had not written out upgrade files after prepare freeze by waiting until after freeze complete is verified
  • updated triggerStakeWeightCalculate to consider what type of Node Subcommand was ran (DELETE/ADD/UPDATE)
  • added const self = this and use of self for when inside of anonymous functions
  • added logic to not download from the node we will be deleting during node delete
  • during node delete set the account id to 0.0.0 so that it can be ignored during the building of the SDK client network
  • add missing freeze with client on transfer amount call
  • hardened support-zip.sh / getNodeLog to be more reliable
  • added kubernetes timeouts to 5 minutes, as sometimes the calls timeout when running with low resources
  • add ability for loading of sdk client to skip a node alias, which is needed for node update
  • added k8 kill pod method that verifies pod is dead that prevents occasional failures
  • added some fixes that stabilizes node add, although teacher node is getting out of memory errors until patch is made in platform/services

Related Issues

…t by platform. bump sdk client timeout configurations. sync file system after writing support-zip.sh. configs to check for invalid this

Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
@jeromy-cannon jeromy-cannon self-assigned this Nov 22, 2024
Copy link
Contributor

github-actions bot commented Nov 22, 2024

Unit Test Results - Linux

  1 files   36 suites   3s ⏱️
109 tests 109 ✅ 0 💤 0 ❌
118 runs  118 ✅ 0 💤 0 ❌

Results for commit 7f7e4a8.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 22, 2024

Unit Test Results - Windows

  1 files   36 suites   11s ⏱️
109 tests 109 ✅ 0 💤 0 ❌
118 runs  118 ✅ 0 💤 0 ❌

Results for commit 7f7e4a8.

♻️ This comment has been updated with latest results.

@jeromy-cannon jeromy-cannon marked this pull request as ready for review November 22, 2024 22:28
@jeromy-cannon jeromy-cannon requested review from a team and leninmehedy as code owners November 22, 2024 22:28
instamenta
instamenta previously approved these changes Nov 25, 2024
Copy link
Contributor

E2E Test Report

 13 files   94 suites   53m 16s ⏱️
198 tests 198 ✅ 0 💤 0 ❌
201 runs  201 ✅ 0 💤 0 ❌

Results for commit 7f7e4a8.

Copy link
Contributor

E2E Test Report

 13 files   94 suites   53m 16s ⏱️
198 tests 198 ✅ 0 💤 0 ❌
201 runs  201 ✅ 0 💤 0 ❌

Results for commit 7f7e4a8.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 5378e8f1 89.03%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5378e8f) Report Missing Report Missing Report Missing
Head commit (7f7e4a8) 14769 12555 85.01%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#866) 319 284 89.03%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 89.02821% with 35 lines in your changes missing coverage. Please review.

Project coverage is 83.82%. Comparing base (b66fe05) to head (7f7e4a8).
Report is 93 commits behind head on main.

Files with missing lines Patch % Lines
src/commands/node/tasks.ts 88.16% 20 Missing ⚠️
src/core/k8.ts 88.23% 10 Missing ⚠️
src/commands/node/handlers.ts 70.00% 3 Missing ⚠️
src/core/helpers.ts 75.00% 1 Missing ⚠️
src/core/logging.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #866      +/-   ##
==========================================
- Coverage   87.09%   83.82%   -3.28%     
==========================================
  Files          40       49       +9     
  Lines       12545    14769    +2224     
  Branches      944     1029      +85     
==========================================
+ Hits        10926    12380    +1454     
- Misses       1568     2370     +802     
+ Partials       51       19      -32     
Files with missing lines Coverage Δ
src/commands/flags.ts 99.56% <100.00%> (+0.06%) ⬆️
src/commands/network.ts 75.73% <100.00%> (-0.69%) ⬇️
src/commands/node/configs.ts 88.34% <100.00%> (-7.11%) ⬇️
src/commands/node/flags.ts 100.00% <100.00%> (ø)
src/core/account_manager.ts 85.24% <100.00%> (+0.74%) ⬆️
src/core/config_manager.ts 93.03% <100.00%> (+0.27%) ⬆️
src/core/constants.ts 96.72% <100.00%> (+0.56%) ⬆️
src/core/enumerations.ts 100.00% <100.00%> (ø)
src/core/platform_installer.ts 89.59% <100.00%> (+0.38%) ⬆️
src/core/helpers.ts 80.52% <75.00%> (-10.81%) ⬇️
... and 4 more

... and 16 files with indirect coverage changes

Impacted file tree graph

@jeromy-cannon jeromy-cannon merged commit 13ea46d into main Nov 25, 2024
37 of 38 checks passed
@jeromy-cannon jeromy-cannon deleted the 00727-solo-inconsistent-starts branch November 25, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve issues with Node Delete E2E tests Inconsistent successful starts of Solo
2 participants