-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auth-layer-proxy helm chart #46
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlfredoG87
added
the
New Feature
A new feature, service, or documentation. Major changes that are not backwards compatible.
label
Mar 29, 2024
AlfredoG87
force-pushed
the
proxy-helm-chart
branch
from
March 30, 2024 02:41
5b46cfa
to
f843ce6
Compare
Wiz Scan Summary
|
Nana-EC
reviewed
Apr 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, some improvement suggestions
Nana-EC
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG.
One doc improvement suggestion
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
…for ease of finding a section. Also ordered alphabetically the `values.yaml` file. minor improvements to the documentation suggested by PR review Signed-off-by: Alfredo Gutierrez <[email protected]>
… secretsEnv values, and included it on a secret.yaml template, that can come from global.auth.clientSecret or from secretsEnv.clientSecret, also added a fallback that generates a random secret in case none is provided. Signed-off-by: Alfredo Gutierrez <[email protected]>
…tSecret since this should be provided by the auth server in use. so this changes make it so that when a clientSecret is not provided the chart installation will fail Signed-off-by: Alfredo Gutierrez <[email protected]>
AlfredoG87
force-pushed
the
proxy-helm-chart
branch
from
April 3, 2024 16:16
ba9b673
to
7219ea2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
New Feature
A new feature, service, or documentation. Major changes that are not backwards compatible.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Did a new chart
charts/auth-layer-proxy
that automatically deploys theauth-layer-proxy
image to K8 with all necessary config and manifests:.Values.configEnv
field.Related issue(s):
Fixes #
Notes for reviewer:
Pending to create documentation changes on
auth-layer-proxy
package and to create a doc for the new chart with instructions on how to run the chart.Checklist