Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth-layer-proxy helm chart #46

Merged
merged 8 commits into from
Apr 15, 2024
Merged

auth-layer-proxy helm chart #46

merged 8 commits into from
Apr 15, 2024

Conversation

AlfredoG87
Copy link
Contributor

@AlfredoG87 AlfredoG87 commented Mar 29, 2024

Description:

Did a new chart charts/auth-layer-proxy that automatically deploys the auth-layer-proxy image to K8 with all necessary config and manifests:

  • configmap: manifest that builds out a configmap to load as env on the image container with all the necessary config env that are configured on .Values.configEnv field.
  • deployment: manifest that creates the deployment using the appropriate repo, tag prefix and tag for deploying the proxy.
  • service: exposes the necessary ports of the deployment pods
  • serviceaccount: if enabled creates a service account for the service.

Related issue(s):

Fixes #

Notes for reviewer:
Pending to create documentation changes on auth-layer-proxy package and to create a doc for the new chart with instructions on how to run the chart.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@AlfredoG87 AlfredoG87 marked this pull request as draft March 29, 2024 04:20
@AlfredoG87 AlfredoG87 self-assigned this Mar 29, 2024
@AlfredoG87 AlfredoG87 added the New Feature A new feature, service, or documentation. Major changes that are not backwards compatible. label Mar 29, 2024
@AlfredoG87 AlfredoG87 added this to the 0.2.0 milestone Mar 29, 2024
@wiz-inc-8f76296f7c
Copy link

wiz-inc-8f76296f7c bot commented Mar 30, 2024

Wiz Scan Summary

IaC Misconfigurations 0C 1H 13M 7L 0I
Vulnerabilities 0C 0H 0M 0L 0I
Sensitive Data 0C 0H 0M 0L 0I
Total 0C 1H 13M 7L 0I
Secrets 0🔑

@AlfredoG87 AlfredoG87 requested a review from Nana-EC April 1, 2024 22:54
@AlfredoG87 AlfredoG87 marked this pull request as ready for review April 1, 2024 22:54
@Nana-EC Nana-EC requested a review from beeradb April 2, 2024 14:27
Copy link

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some improvement suggestions

charts/auth-layer-proxy/README.md Show resolved Hide resolved
charts/auth-layer-proxy/README.md Outdated Show resolved Hide resolved
Copy link

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG.
One doc improvement suggestion

charts/auth-layer-proxy/values.yaml Outdated Show resolved Hide resolved
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
…for ease of finding a section.

Also ordered alphabetically the `values.yaml` file.

minor improvements to the documentation suggested by PR review

Signed-off-by: Alfredo Gutierrez <[email protected]>
… secretsEnv values, and included it on a secret.yaml template, that can come from global.auth.clientSecret or from secretsEnv.clientSecret, also added a fallback that generates a random secret in case none is provided.

Signed-off-by: Alfredo Gutierrez <[email protected]>
…tSecret since this should be provided by the auth server in use.

so this changes make it so that when a clientSecret is not provided the chart installation will fail

Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87 AlfredoG87 merged commit 62326c0 into main Apr 15, 2024
8 checks passed
@AlfredoG87 AlfredoG87 deleted the proxy-helm-chart branch April 15, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature A new feature, service, or documentation. Major changes that are not backwards compatible.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants