-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added the new function hashes and updated the precompiles and tests #4067
Conversation
Codecov ReportBase: 85.53% // Head: 96.54% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #4067 +/- ##
==============================================
+ Coverage 85.53% 96.54% +11.01%
- Complexity 13513 14719 +1206
==============================================
Files 982 982
Lines 47263 42021 -5242
Branches 5045 4251 -794
==============================================
+ Hits 40426 40571 +145
+ Misses 6107 714 -5393
- Partials 730 736 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
...ce/src/main/java/com/hedera/services/store/contracts/precompile/impl/TransferPrecompile.java
Outdated
Show resolved
Hide resolved
...ervice/src/main/java/com/hedera/services/store/contracts/precompile/impl/MintPrecompile.java
Outdated
Show resolved
Hide resolved
...rvice/src/main/java/com/hedera/services/store/contracts/precompile/codec/DecodingFacade.java
Outdated
Show resolved
Hide resolved
...ervice/src/main/java/com/hedera/services/store/contracts/precompile/impl/BurnPrecompile.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/hedera/services/store/contracts/precompile/impl/TokenCreatePrecompile.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/hedera/services/store/contracts/precompile/impl/TokenCreatePrecompile.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to extract the common logic from all decoding methods. For most of them, the only difference is passing different method signature for Tuple decode. From there, the creation of the Wrapper records follow the same logic for a given method (e.g. burn, mint, token create).
@georg-getz please note this related upcoming change also. You can add the new selector support for int64 in this case |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
...src/main/java/com/hedera/services/store/contracts/precompile/impl/TokenUpdatePrecompile.java
Show resolved
Hide resolved
Signed-off-by: Georgi Georgiev <[email protected]>
a4af71c
to
99a0c2a
Compare
Signed-off-by: Georgi Georgiev <[email protected]>
Signed-off-by: Georgi Georgiev <[email protected]>
Signed-off-by: Georgi Georgiev <[email protected]>
Signed-off-by: Georgi Georgiev <[email protected]>
…y version 2 Signed-off-by: Georgi Georgiev <[email protected]>
Signed-off-by: Georgi Georgiev <[email protected]>
Signed-off-by: Georgi Georgiev <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
…4067) Signed-off-by: Georgi Georgiev <[email protected]>
Signed-off-by: Georgi Georgiev [email protected]
Description:
Follow-up PR to the changes made in the smart contracts repo in order to remove uints from selectors.
It adds new versions in the AbiConstants for the smart contract functions. Precompiles and tests are updated accordingly. Due to the
Expiry
struct in the smart contracts repo having its numeric values changed combined with the fact that theHederaToken
struct contains anExpiry
type a lot of functions required a new decoding logic to be added which introduced new versions of functions being added as well.Related issue(s):
hashgraph/hedera-smart-contracts#99
hashgraph/hedera-protobufs#235
Checklist