Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update glossary defns of aliases, triplets #14372

Merged
merged 1 commit into from
Jul 30, 2024
Merged

docs: Update glossary defns of aliases, triplets #14372

merged 1 commit into from
Jul 30, 2024

Conversation

david-bakin-sl
Copy link
Member

Description:

Update definitions of alias - there are several different kinds - and triplets.

Checklist

  • Documented (Code comments, README, etc.)
  • [N/A] Tested (unit, integration, etc.)

@david-bakin-sl david-bakin-sl added the Hedera Smart Contract Service Issues related to the Hedera Smart Contract Service. label Jul 24, 2024
@david-bakin-sl david-bakin-sl added this to the v0.53 milestone Jul 24, 2024
@david-bakin-sl david-bakin-sl self-assigned this Jul 24, 2024
@david-bakin-sl david-bakin-sl requested review from a team as code owners July 24, 2024 03:39
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

Node: HAPI Test (Time Consuming) Results

19 tests   19 ✅  22m 24s ⏱️
 4 suites   0 💤
 4 files     0 ❌

Results for commit 690a05f.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

Node: HAPI Test (Smart Contract) Results

 88 files   88 suites   24m 6s ⏱️
656 tests 656 ✅ 0 💤 0 ❌
823 runs  823 ✅ 0 💤 0 ❌

Results for commit 690a05f.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

Node: HAPI Test (Restart) Results

4 tests   0 ✅  4m 30s ⏱️
4 suites  0 💤
4 files    4 ❌

For more details on these failures, see this check.

Results for commit 690a05f.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

Node: HAPI Test (Token) Results

 22 files   22 suites   6m 24s ⏱️
281 tests 281 ✅ 0 💤 0 ❌
364 runs  364 ✅ 0 💤 0 ❌

Results for commit 690a05f.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

Node: HAPI Test (Crypto) Results

 24 files   24 suites   10m 27s ⏱️
347 tests 347 ✅ 0 💤 0 ❌
372 runs  372 ✅ 0 💤 0 ❌

Results for commit 690a05f.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

Node: HAPI Test (Node Death Reconnect) Results

3 tests   3 ✅  4m 55s ⏱️
3 suites  0 💤
3 files    0 ❌

Results for commit 690a05f.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

Node: HAPI Test (Misc) Results

 61 files   61 suites   16m 58s ⏱️
318 tests 318 ✅ 0 💤 0 ❌
408 runs  408 ✅ 0 💤 0 ❌

Results for commit 690a05f.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

Node: Unit Test Results

  1 539 files    1 539 suites   3h 58m 20s ⏱️
117 404 tests 117 345 ✅ 59 💤 0 ❌
125 618 runs  125 559 ✅ 59 💤 0 ❌

Results for commit 690a05f.

♻️ This comment has been updated with latest results.

lukelee-sl
lukelee-sl approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@lukelee-sl lukelee-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small comment - feel free to ignore. LGTM

MrValioBg
MrValioBg approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@MrValioBg MrValioBg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tyvm!

@david-bakin-sl david-bakin-sl merged commit 6565bbf into develop Jul 30, 2024
40 of 43 checks passed
@david-bakin-sl david-bakin-sl deleted the aliases-in-glossary branch July 30, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsync-swirlds jsync-swirlds jsync-swirlds left review comments

@lukelee-sl lukelee-sl lukelee-sl approved these changes

@JeffreyDallas JeffreyDallas JeffreyDallas approved these changes

@MrValioBg MrValioBg MrValioBg approved these changes

@jeromy-cannon jeromy-cannon jeromy-cannon approved these changes

@dalvizu dalvizu Awaiting requested review from dalvizu dalvizu is a code owner automatically assigned from hashgraph/devops-ci

@nathanklick nathanklick Awaiting requested review from nathanklick nathanklick is a code owner automatically assigned from hashgraph/release-engineering-managers

@Nana-EC Nana-EC Awaiting requested review from Nana-EC

@thomas-swirlds-labs thomas-swirlds-labs Awaiting requested review from thomas-swirlds-labs

Assignees

@david-bakin-sl david-bakin-sl

Labels
Hedera Smart Contract Service Issues related to the Hedera Smart Contract Service.
Projects
Smart Contract Sprint Board
Status: Done
Milestone
v0.53
Development

Successfully merging this pull request may close these issues.
6 participants
@david-bakin-sl @jeromy-cannon @MrValioBg @JeffreyDallas @lukelee-sl @jsync-swirlds