Skip to content

Commit

Permalink
chore: Merge protobuf changes back to services
Browse files Browse the repository at this point in the history
 * Merged all changes from [PR 388](hashgraph/hedera-protobufs#388) in `hedera-protobufs`
 * Removed references in test clients to obsolete removed functionality
 * Removed three unused imports.
 * Removed HAPI tests for unsupported queries that are removed.

Signed-off-by: Joseph Sinclair <[email protected]>
  • Loading branch information
jsync-swirlds committed Dec 12, 2024
1 parent 93693c3 commit f9b82cb
Show file tree
Hide file tree
Showing 139 changed files with 11,305 additions and 5,201 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ option java_package = "com.hedera.hapi.block.stream.output.protoc";
// <<<pbj.java_package = "com.hedera.hapi.block.stream.output">>> This comment is special code for setting PBJ Compiler java package
option java_multiple_files = true;

import "contract_call_local.proto";
import "contract_types.proto";
import "sidecar_file.proto";

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ import "stream/output/smart_contract_service.proto";
* >> Only a few transactions produce output that is not in the transaction
* >> and also not reflected in state changes. All other transaction types
* >> are _currently_ not included here. We have, however, allocated names
* >> and indexes for those transaction types to preserve consistency if we
* >> for those transaction types to preserve consistency if we
* >> add them later.
*
* <!--
Expand Down
1 change: 0 additions & 1 deletion hapi/hedera-protobufs/block/stream/record_file_item.proto
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ option java_package = "com.hedera.hapi.block.stream.protoc";
// <<<pbj.java_package = "com.hedera.hapi.block.stream">>> This comment is special code for setting PBJ Compiler java package
option java_multiple_files = true;

import "basic_types.proto";
import "timestamp.proto";

/**
Expand Down
31 changes: 20 additions & 11 deletions hapi/hedera-protobufs/services/address_book_service.proto
Original file line number Diff line number Diff line change
@@ -1,3 +1,14 @@
/**
* # Address Book Service API
* GRPC service definitions for the Hedera Address Book Service (HABS).
*
* ### Keywords
* The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT",
* "SHOULD", "SHOULD NOT", "RECOMMENDED", "MAY", and "OPTIONAL" in this
* document are to be interpreted as described in
* [RFC2119](https://www.ietf.org/rfc/rfc2119) and clarified in
* [RFC8174](https://www.ietf.org/rfc/rfc8174).
*/
syntax = "proto3";

package proto;
Expand All @@ -21,8 +32,6 @@ package proto;
option java_package = "com.hederahashgraph.service.proto.java";
// <<<pbj.java_package = "com.hedera.hapi.node.addressbook">>> This comment is special code for setting PBJ Compiler java package

import "query.proto";
import "response.proto";
import "transaction_response.proto";
import "transaction.proto";

Expand All @@ -38,9 +47,9 @@ import "transaction.proto";
*
* ### For a node creation transaction.
* - The node operator SHALL create a `createNode` transaction.
* - The node operator SHALL sign this transaction with the active `key` for
* the account to be assigned as the "node account".
* - The node operator MUST deliver the signed transaction to the Hedera
* - The node operator MUST sign this transaction with the `Key`
* set as the `admin_key` for the new `Node`.
* - The node operator SHALL deliver the signed transaction to the Hedera
* council representative.
* - The Hedera council representative SHALL arrange for council members to
* review and sign the transaction.
Expand All @@ -50,8 +59,8 @@ import "transaction.proto";
* - Upon receipt of a valid and signed node creation transaction the network
* software SHALL
* - Validate the threshold signature for the Hedera governing council
* - Validate the signature of the active `key` for the account to be
* assigned as the "node account".
* - Validate the signature of the `Key` provided as the new `admin_key`
* for the `Node`.
* - Create the new node in state, this new node SHALL NOT be active in the
* network at this time.
* - When executing the next `freeze` transaction with `freeze_type` set to
Expand All @@ -63,8 +72,8 @@ import "transaction.proto";
* - The node operator or Hedera council representative SHALL create a
* `deleteNode` transaction.
* - If the node operator creates the transaction
* - The node operator MUST sign this transaction with the active `key`
* for the account assigned as the "node account".
* - The node operator MUST sign this transaction with the `Key`
* set as the `admin_key` for the existing `Node`.
* - The node operator SHALL deliver the signed transaction to the Hedera
* council representative.
* - The Hedera council representative SHALL arrange for council members to
Expand All @@ -74,7 +83,7 @@ import "transaction.proto";
* network.
* - Upon receipt of a valid and signed node deletion transaction the network
* software SHALL
* - Validate the threshold signature for the Hedera governing council
* - Validate the signature for the Hedera governing council
* - Remove the existing node from network state. The node SHALL still
* be active in the network at this time.
* - When executing the next `freeze` transaction with `freeze_type` set to
Expand Down Expand Up @@ -107,7 +116,7 @@ import "transaction.proto";
*/
service AddressBookService {
/**
* A transaction to create a new consensus node in the network.
* A transaction to create a new consensus node in the network
* address book.
* <p>
* This transaction, once complete, SHALL add a new consensus node to the
Expand Down
Loading

0 comments on commit f9b82cb

Please sign in to comment.