Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toECDSAsecp256k1PrivateKey & derive legacy ecdsa private key #418

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

RickyLB
Copy link
Contributor

@RickyLB RickyLB commented Dec 10, 2024

Description:

This PR incorporates Mnemonic.toStandardECDSAsecp256k1PrivateKey()

  • Mnemonic.toStandardECDSAsecp256k1PrivateKey
  • Derive Legacy ECDSA

Related issue(s):

Fixes

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@RickyLB RickyLB requested review from a team as code owners December 10, 2024 20:21
@RickyLB RickyLB requested a review from rwalworth December 10, 2024 20:21
@RickyLB RickyLB force-pushed the feat/mnemonic_account_id branch from 2c42cb9 to bde9b4e Compare December 10, 2024 20:44
@RickyLB RickyLB marked this pull request as draft December 10, 2024 20:54
@RickyLB RickyLB marked this pull request as ready for review December 16, 2024 23:37
@RickyLB RickyLB force-pushed the feat/mnemonic_account_id branch from bde9b4e to cb85ebf Compare December 17, 2024 16:03
@RickyLB RickyLB requested review from a team as code owners December 17, 2024 16:03
@RickyLB RickyLB force-pushed the feat/mnemonic_account_id branch 2 times, most recently from 3938b77 to 2a03c32 Compare December 18, 2024 19:05
@RickyLB RickyLB force-pushed the feat/mnemonic_account_id branch from 2a03c32 to 77c8da2 Compare December 18, 2024 19:14
@RickyLB RickyLB requested a review from Sheng-Long December 18, 2024 19:16
Sheng-Long
Sheng-Long previously approved these changes Dec 18, 2024
Signed-off-by: Ricky Saechao <[email protected]>
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
21.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@RickyLB RickyLB requested a review from Sheng-Long December 18, 2024 21:08
@RickyLB RickyLB changed the title Add Mnemonic.toStandardECDSAsecp256k1PrivateKey toECDSAsecp256k1PrivateKey & derive legacy ecdsa private key Dec 18, 2024
@RickyLB RickyLB merged commit c65028c into hashgraph:main Dec 18, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants