-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(TCK): Implement JSON-RPC endpoint for AccountUpdateTransaction
#408
feat(TCK): Implement JSON-RPC endpoint for AccountUpdateTransaction
#408
Conversation
Signed-off-by: Rob Walworth <[email protected]>
AccountUpdateTransaction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit. Otherwise, LGTM!
…action-json-rpc-method-endpoint
…toTokenAssociations an int32 Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
…action-json-rpc-method-endpoint
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
This PR adds the JSON-RPC
updateAccount
to serviceAccountUpdateTransaction
TCK tests. A tweak was made to the SDK itself as well to allowTimestamp
s to parse unsigned integers to protobuf fields.Related issue(s):
Fixes #403
Checklist