Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TCK): Implement JSON-RPC endpoint for AccountUpdateTransaction #408

Conversation

rwalworth
Copy link
Contributor

Description:
This PR adds the JSON-RPC updateAccount to service AccountUpdateTransaction TCK tests. A tweak was made to the SDK itself as well to allow Timestamps to parse unsigned integers to protobuf fields.

Related issue(s):

Fixes #403

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@rwalworth rwalworth added the enhancement New feature or request label Nov 12, 2024
@rwalworth rwalworth self-assigned this Nov 12, 2024
@rwalworth rwalworth requested review from a team as code owners November 12, 2024 21:34
@rwalworth rwalworth changed the title feat(TCK): Implement JSON-RPC endpoint for `AccountUpdateTransaction) feat(TCK): Implement JSON-RPC endpoint for AccountUpdateTransaction Nov 12, 2024
Copy link
Contributor

@RickyLB RickyLB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit. Otherwise, LGTM!

Copy link

sonarcloud bot commented Nov 19, 2024

Copy link
Contributor

@RickyLB RickyLB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RickyLB RickyLB merged commit cfb2cce into main Nov 20, 2024
15 checks passed
@RickyLB RickyLB deleted the 00403-tck-swift-implement-accountupdatetransaction-json-rpc-method-endpoint branch November 20, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TCK-Swift: Implement AccountUpdateTransaction JSON-RPC method endpoint
2 participants