Add runbook to restore stackgres backup #9860
Open
+460
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volumes Signed-off-by: Xin Li <[email protected]>
…ckup Signed-off-by: Xin Li <[email protected]>
Signed-off-by: Xin Li <[email protected]>
Signed-off-by: Xin Li <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9860 +/- ##
============================================
- Coverage 92.27% 92.26% -0.01%
Complexity 7771 7771
============================================
Files 951 951
Lines 32472 32472
Branches 4118 4118
============================================
- Hits 29962 29961 -1
Misses 1546 1546
- Partials 964 965 +1 ☔ View full report in Codecov by Sentry. |
xin-hedera
commented
Dec 2, 2024
xin-hedera
commented
Dec 2, 2024
Comment on lines
+27
to
+28
| read -p "Continue? (Y/N): " confirm && [[ $confirm == [yY] || $confirm == [yY][eE][sS] ]] && return || \ | ||
| { [[ -n "$confirm" ]] && exit 1 || true; } |
There was a problem hiding this comment.
change the function to ignore empty input
jnels124
reviewed
Dec 3, 2024
| done | ||
| } | ||
| CURRENT_NAMESPACE=$(kubectl config view --minify --output 'jsonpath={..namespace}') |
There was a problem hiding this comment.
Maybe add to requirements in the .md?
steven-sheehy
previously approved these changes
Dec 3, 2024
...ror-web3/src/test/java/com/hedera/services/fees/calculation/UsageBasedFeeCalculatorTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Xin Li <[email protected]>
xin-hedera
dismissed stale reviews from steven-sheehy and jnels124
via
44f8461
Signed-off-by: Xin Li <[email protected]>
steven-sheehy
approved these changes
Dec 3, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds a script to restore stackgres backup
Related issue(s):
Fixes #9577
Notes for reviewer:
Tested the following scenario:
coord-1instead of the default coordinator primarycoord-0Overall rolling back a ZFS volume to a snapshot and recover the saved WAL files are fast, however it make take longer if the data diff size is larger between the snapshot and the current volume.
The more time consuming part is re-initializing the coordinator replica from the primary, it took about 5 minutes for testnet with 5GB coordinator data.
Checklist