Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spotlessCheck job to the security CI workflow #9839

Closed
wants to merge 7 commits into from

Conversation

sdimitrov9
Copy link
Contributor

Description:
This PR adds spotlessCheck job to the security CI workflow.

Related issue(s):

Fixes #9023

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@sdimitrov9 sdimitrov9 added the enhancement Type: New feature label Nov 27, 2024
@sdimitrov9 sdimitrov9 self-assigned this Nov 27, 2024
@sdimitrov9 sdimitrov9 requested review from a team as code owners November 27, 2024 11:53
@sdimitrov9 sdimitrov9 linked an issue Nov 27, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.27%. Comparing base (67adf6b) to head (09bdc87).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #9839   +/-   ##
=========================================
  Coverage     92.26%   92.27%           
  Complexity     7771     7771           
=========================================
  Files           951      951           
  Lines         32472    32472           
  Branches       4118     4118           
=========================================
+ Hits          29961    29962    +1     
  Misses         1546     1546           
+ Partials        965      964    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

edwin-greene
edwin-greene previously approved these changes Nov 27, 2024
Copy link
Contributor

@edwin-greene edwin-greene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@steven-sheehy steven-sheehy added this to the 0.120.0 milestone Nov 29, 2024
Copy link
Member

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to merge from main and verify spotless check now passes

.github/workflows/security.yml Outdated Show resolved Hide resolved
.github/workflows/security.yml Outdated Show resolved Hide resolved
.github/workflows/security.yml Outdated Show resolved Hide resolved
.github/workflows/security.yml Outdated Show resolved Hide resolved
@sdimitrov9
Copy link
Contributor Author

Need to merge from main and verify spotless check now passes

Done.

.github/workflows/security.yml Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Dec 2, 2024

@sdimitrov9 sdimitrov9 force-pushed the 9023-verify-spotless-in-ci branch 2 times, most recently from 74737cd to f8eb166 Compare December 3, 2024 15:44
@sdimitrov9 sdimitrov9 marked this pull request as draft December 3, 2024 16:06
@steven-sheehy steven-sheehy removed this from the 0.120.0 milestone Dec 3, 2024
@steven-sheehy steven-sheehy deleted the 9023-verify-spotless-in-ci branch December 3, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify Spotless in CI
4 participants