Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace use of deprecated DirectProcessor #5187

Open
2 of 11 tasks
edwin-greene opened this issue Jan 9, 2023 · 2 comments · May be fixed by #9630
Open
2 of 11 tasks

Replace use of deprecated DirectProcessor #5187

edwin-greene opened this issue Jan 9, 2023 · 2 comments · May be fixed by #9630
Assignees
Labels
enhancement Type: New feature good first issue Good for newcomers grpc Area: GRPC API hacktoberfest Issues shown by lists for the Hacktoberfest and made for newcomers to do the first contribution.

Comments

@edwin-greene
Copy link
Contributor

edwin-greene commented Jan 9, 2023

🆕🐥 First Timers Only

This issue is reserved for people who have never contributed to Hedera or any open source project in general.
We know that creating a pull request (PR) is a major barrier for new contributors.
The goal of this issue and all other issues labeled by 'good first issue' is to help you make your first contribution to Hedera.

👾 Description of the issue

SharedTopicListener uses reactor.core.publisher.DirectProcessor, which is deprecated.

Solution

Update SharedTopicListener to use Project Reactor Sinks.

Ensure the Sink implementation is as performant as the DirectProcesser. That can be done by creating a JMH test for SharedTopicListener. It would be great to have it but it is not a must to solve the issue.

📋 Step by step guide to do a contribution

If you have never contributed to an open source project at GitHub, the following step-by-step guide will introduce you to the workflow. More information and concrete samples for shell commands for each step can be found in our CONTRIBUTING.md file.
A more detailed general documentation of the GitHub PR workflow can be found here.

  • Claim this issue: Comment below that you are interested in working on the issue
  • Wait for assignment: A community member with the given rights will add you as an assignee of the issue
  • Fork the repository: You can do that in GitHub (by simply clicking the 'fork' button).
  • Check out the forked repository
  • Create a feature branch for the issue. We do not have a hard naming definition for branches but it is best practice to prefix the branch name with the issue id.
  • Solve the issue in your branch.
  • Commit your changes: Here, it is needed to add sign-off information to the commit to accept the "Developer Certificate of Origin" (https://developercertificate.org). More details can be found in our CONTRIBUTING.md
  • Start a Pull Request (PR): We have a pattern for naming pull requests that a GitHub Action checks. We use that pattern to support the creation of automatic release notes.
  • Check GitHub Actions: Several GitHub Actions will be triggered automatically for each PR. If a GitHub Action fails and you do not understand the cause of that error do not hesitate to add a comment to the PR and ask the Hedera developer community for support.
  • Wait for reviews: Members of the Hedera developer community will review your PR. If a reviewer finds any missing pieces or a problem, he or she will start a discussion with you and describe the next steps for solving the problem.
  • You did it 🎉: We will merge the fix in the develop branch. Thanks for being part of the Hedera community as an open-source contributor ❤️

🎉 Contribute to Hacktoberfest

Solve this issue as part of the Hacktoberfest event and get a chance to receive cool goodies like a T-Shirt. 🎽

🤔 Additional Information

If you have any questions, just ask us directly in this issue by adding a comment. You can join our community chat at Discord. A general manual about open-source contributions can be found here.

@edwin-greene edwin-greene added the enhancement Type: New feature label Jan 9, 2023
@steven-sheehy steven-sheehy changed the title Update Reactor Core to latest version Replace use of deprecated DirectProcessor Jan 11, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Mirror Node Jan 30, 2024
@steven-sheehy steven-sheehy moved this from 📋 Backlog to 🏃‍♀ Sprint backlog in Mirror Node Jan 30, 2024
@steven-sheehy steven-sheehy added good first issue Good for newcomers grpc Area: GRPC API labels Jan 30, 2024
@steven-sheehy steven-sheehy moved this from 🏃‍♀ Sprint backlog to 📋 Backlog in Mirror Node Feb 5, 2024
@hendrikebbers hendrikebbers added good first issue candidate Issues that can become a good first issue but need more description/context. and removed good first issue Good for newcomers labels Sep 30, 2024
@hendrikebbers hendrikebbers added good first issue Good for newcomers hacktoberfest Issues shown by lists for the Hacktoberfest and made for newcomers to do the first contribution. and removed good first issue candidate Issues that can become a good first issue but need more description/context. labels Oct 17, 2024
@saai-syvendra
Copy link

I'll work on this issue

@steven-sheehy
Copy link
Member

Thanks @saai-syvendra. I've assigned you the issue. Let me know if you need any guidance.

@saai-syvendra saai-syvendra linked a pull request Oct 24, 2024 that will close this issue
2 tasks
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Mirror Node Nov 25, 2024
@steven-sheehy steven-sheehy moved this from 📋 Backlog to 👀 In review in Mirror Node Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature good first issue Good for newcomers grpc Area: GRPC API hacktoberfest Issues shown by lists for the Hacktoberfest and made for newcomers to do the first contribution.
Projects
Status: 👀 In review
Development

Successfully merging a pull request may close this issue.

4 participants