Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remaining sonar code smells #5189

Closed
edwin-greene opened this issue Jan 9, 2023 · 0 comments · Fixed by #5194
Closed

Fix remaining sonar code smells #5189

edwin-greene opened this issue Jan 9, 2023 · 0 comments · Fixed by #5194
Assignees
@MarcKriguerAtHedera
Labels
bug Type: Something isn't working good first issue Good for newcomers
Milestone
0.73.0

Comments

@edwin-greene
Copy link
Contributor

edwin-greene commented Jan 9, 2023 •
edited by steven-sheehy
Loading

Description

SonarCloud lists a number of remaining code smells that we should fix except for #5187 to have cleaner code.

Steps to reproduce

View the list of code smells in SonarCloud

Additional context

No response

Hedera network

other

Version

0.73.0-SNAPSHOT

Operating system

Other
@edwin-greene edwin-greene added the bug Type: Something isn't working label Jan 9, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Mirror Node Jan 9, 2023
@edwin-greene edwin-greene moved this from 📋 Backlog to 🏃‍♀ Sprint backlog in Mirror Node Jan 9, 2023
@steven-sheehy steven-sheehy added the good first issue Good for newcomers label Jan 9, 2023
@MarcKriguerAtHedera MarcKriguerAtHedera self-assigned this Jan 10, 2023
@MarcKriguerAtHedera MarcKriguerAtHedera moved this from 🏃‍♀ Sprint backlog to 👷 In progress in Mirror Node Jan 10, 2023
@MarcKriguerAtHedera MarcKriguerAtHedera mentioned this issue Jan 11, 2023
Merged
2 tasks
@MarcKriguerAtHedera MarcKriguerAtHedera linked a pull request Jan 11, 2023 that will close this issue
Fix remaining Sonar code smells #5194
Merged
2 tasks
@steven-sheehy steven-sheehy moved this from 👷 In progress to 👀 In review in Mirror Node Jan 11, 2023
@steven-sheehy steven-sheehy added this to the 0.73.0 milestone Jan 11, 2023
@steven-sheehy steven-sheehy changed the title Fix "Blocker" and "Critical" Code Smells Fix remaining sonar code smells Jan 11, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Mirror Node Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarcKriguerAtHedera MarcKriguerAtHedera

Labels
bug Type: Something isn't working good first issue Good for newcomers
Projects
Mirror Node
Archived in project
Milestone
0.73.0
Development

Successfully merging a pull request may close this issue.

Fix remaining Sonar code smells hashgraph/hedera-mirror-node
3 participants
@steven-sheehy @MarcKriguerAtHedera @edwin-greene