Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add layer zero examples #3326

Merged
merged 14 commits into from
Jan 8, 2025
Merged

feat: add layer zero examples #3326

merged 14 commits into from
Jan 8, 2025

Conversation

natanasow
Copy link
Collaborator

@natanasow natanasow commented Dec 11, 2024

@natanasow natanasow self-assigned this Dec 11, 2024
Copy link

github-actions bot commented Dec 11, 2024

Test Results

 18 files   -   2  236 suites   - 24   32m 45s ⏱️ - 8m 52s
612 tests ±  0  608 ✅ +  2  4 💤 ±0  0 ❌  - 2 
628 runs   - 129  624 ✅  - 125  4 💤  - 2  0 ❌  - 2 

Results for commit 7be6b32. ± Comparison against base commit b5e747f.

♻️ This comment has been updated with latest results.

Signed-off-by: nikolay <[email protected]>
@natanasow natanasow added this to the 0.64.0 milestone Dec 12, 2024
@natanasow natanasow added the dev tools Features enabling dev tool integration label Dec 12, 2024
@natanasow natanasow marked this pull request as ready for review December 16, 2024 15:02
Copy link
Member

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without context it's quite hard to follow the PR. Could you provide a design document or any documentation that outlines the purpose of the project? The document could also define terms such as OFT and OApp. I believe the document you shared with the team last Friday was very effective. Would you consider updating and including it in this project?

@quiet-node quiet-node added the internal For changes that affect the project's internal workings but not its outward-facing functionality. label Dec 16, 2024
Signed-off-by: nikolay <[email protected]>
@natanasow natanasow requested review from a team as code owners December 18, 2024 13:00
@natanasow natanasow requested a review from dalvizu December 18, 2024 13:00
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice progress, some suggestions

Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.
Some suggestions to make it easy to illustrate the E2E flow

tools/layer-zero-example/contracts/HTSConnector.sol Outdated Show resolved Hide resolved
tools/layer-zero-example/contracts/HTSConnector.sol Outdated Show resolved Hide resolved
tools/layer-zero-example/contracts/HTSConnector.sol Outdated Show resolved Hide resolved
tools/layer-zero-example/hardhat.config.js Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Jan 6, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
3.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, in general we've got the coverage we were looking for.
There's a few tweaks and additions we can make but i'd prefer this PR doesn't get anymore scope creep so let's get this in and address other improvements in follow up since these flows are giving the E2E examples we had hoped for

Copy link
Member

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! LGTM. Just some nits and questions which can be addressed in next PRs

@Nana-EC Nana-EC merged commit 68fce9a into main Jan 8, 2025
46 of 47 checks passed
@Nana-EC Nana-EC deleted the 1030-lz-setup branch January 8, 2025 05:19
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.06%. Comparing base (b5e747f) to head (7be6b32).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3326      +/-   ##
==========================================
+ Coverage   84.91%   85.06%   +0.14%     
==========================================
  Files          69       69              
  Lines        4655     4688      +33     
  Branches     1042     1050       +8     
==========================================
+ Hits         3953     3988      +35     
+ Misses        397      390       -7     
- Partials      305      310       +5     
Flag Coverage Δ
config-service 98.14% <ø> (ø)
relay 79.72% <ø> (+0.96%) ⬆️
server 83.28% <ø> (ø)
ws-server 36.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev tools Features enabling dev tool integration internal For changes that affect the project's internal workings but not its outward-facing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LZ <-> Hedera examples
6 participants