-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add layer zero examples #3326
Conversation
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without context it's quite hard to follow the PR. Could you provide a design document or any documentation that outlines the purpose of the project? The document could also define terms such as OFT and OApp. I believe the document you shared with the team last Friday was very effective. Would you consider updating and including it in this project?
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice progress, some suggestions
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work.
Some suggestions to make it easy to illustrate the E2E flow
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Quality Gate failedFailed conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG, in general we've got the coverage we were looking for.
There's a few tweaks and additions we can make but i'd prefer this PR doesn't get anymore scope creep so let's get this in and address other improvements in follow up since these flows are giving the E2E examples we had hoped for
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! LGTM. Just some nits and questions which can be addressed in next PRs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3326 +/- ##
==========================================
+ Coverage 84.91% 85.06% +0.14%
==========================================
Files 69 69
Lines 4655 4688 +33
Branches 1042 1050 +8
==========================================
+ Hits 3953 3988 +35
+ Misses 397 390 -7
- Partials 305 310 +5
Flags with carried forward coverage won't be shown. Click here to find out more. |
Description:
LZ is deployed on Hedera and we'd like to dig into see what's possible when considering HTS and it's representation fo ERC20 and ERC 721s.
Explore the LZ offering, and gain familiarity as a team and POC so cross-chain bridging of HTS tokens
Self-improvement docs:
Tasks
Related issue(s):
Fixes #3339
Notes for reviewer:
Checklist