feat: remove transactions with status INVALID_ACCOUNT_ID from block-specific routes

[natanasow]

Description:

Currently, there are transactions that hadn't entered the evm (reverted due to hedera-specific validations) but are included in a generated record file, also they are imported in the mirror node db. These transactions must be excluded from the response to block-related routes.

Solutions:

We should hook in here https://github.com/hashgraph/hedera-json-rpc-relay/pull/3158/files#diff-dd8c7990f7764960d05dcb4c1b5ae7eee48b425b1b83d6dcc7e7ccc442330ef0R2303 and add a type for INVALID_ACCOUNT_ID as well.

These checks must be defined as an environment variable (as an array) and we could be able easily to add/remove transaction statuses.

Related issue(s):

Fixes #3171

Notes for reviewer:

Checklist

• Documented (Code comments, README, etc.)
• Tested (unit, integration, etc.)

[github-actions]

🚨 Memory Leak Detected 🚨

A potential memory leak has been detected in the test titled validates enforcement of request id. This may impact the application's performance and stability.

Details

📊 Memory Leak Detection Report 📊

GC Type: MarkSweepCompact
Cost: 30,549.4 ms

Heap Statistics (before vs after executing the test):

• Total Heap Size: increased with 1.46 MB
• Total Heap Size Executable: no changes
• Total Physical Size: decreased with 348.16 KB
• Total Available Size: decreased with 7.20 MB
• Total Global Handles Size: no changes
• Used Global Handles Size: decreased with 64.00 bytes
• Used Heap Size: decreased with 3.45 MB
• Heap Size Limit: no changes
• Malloced Memory: no changes
• External Memory: no changes
• Peak Malloced Memory: no changes

Heap Space Statistics (before vs after executing the test):

• Old Space:

  • Space Size: increased with 1.84 MB
  • Space Used Size: increased with 2.07 MB
  • Space Available Size: decreased with 10.22 MB
  • Physical Space Size: increased with 1.84 MB

• Large Object Space:

  • Space Size: increased with 835.58 KB
  • Space Used Size: increased with 813.50 KB
  • Space Available Size: no changes
  • Physical Space Size: increased with 835.58 KB

Recommendations

Please investigate the memory allocations in this test, focusing on objects that are not being properly deallocated.

[github-actions]

Test Results

 17 files   -   3  229 suites   - 42   28m 51s ⏱️ - 11m 43s
603 tests  -   1  599 ✅ +  4  4 💤 ±0  0 ❌  - 5 
619 runs   - 114  615 ✅  - 108  4 💤  - 1  0 ❌  - 5 

Results for commit a41beb1. ± Comparison against base commit 7fea98c.

This pull request removes 1 test.

"before all" hook for "should execute "eth_getCode" for hts token" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-2 RPC Server Acceptance Tests eth_getCode "before all" hook for "should execute "eth_getCode" for hts token"

♻️ This comment has been updated with latest results.

[victor-yanev]

Nice work! A few suggestions:

[Nana-EC]

Looking good.
I provided a log suggestion and a test suggestion that should be addressed.
Thanks

[quiet-node]

LG just 1 small request and a qq

[quiet-node]

LGTM

[quiet-node]

LGTM

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.80%. Comparing base (7fea98c) to head (a41beb1).
Report is 34 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3177      +/-   ##
==========================================
- Coverage   83.35%   82.80%   -0.56%     
==========================================
  Files          66       69       +3     
  Lines        4290     4477     +187     
  Branches      837      883      +46     
==========================================
+ Hits         3576     3707     +131     
- Misses        473      501      +28     
- Partials      241      269      +28     

Flag	Coverage Δ
config-service	98.14% <ø> (ø)
relay	85.23% <100.00%> (-0.31%)	⬇️
server	83.52% <ø> (ø)
ws-server	36.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...ckages/config-service/src/services/globalConfig.ts	100.00% <ø> (ø)
packages/relay/src/lib/eth.ts	83.33% <100.00%> (+1.00%)	⬆️
packages/relay/src/utils.ts	100.00% <100.00%> (ø)

... and 15 files with indirect coverage changes

---- 🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles