fix: removed name field in JsonRpcError class #2590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quiet-node
requested review from
AlfredoG87,
ebadiere,
georgi-l95 and
Ivo-Yankov
as code owners
quiet-node
force-pushed
the
2589-relay-error-response-is-not-conforming-to-the-json-rpc-20-specification
branch
4 times, most recently
from
7c0b1e8 to
1f1a4e0
Compare
quiet-node
force-pushed
the
2589-relay-error-response-is-not-conforming-to-the-json-rpc-20-specification
branch
from
6092489 to
9f5296c
Compare
quiet-node
force-pushed
the
2589-relay-error-response-is-not-conforming-to-the-json-rpc-20-specification
branch
2 times, most recently
from
a0f143f to
c8024e3
Compare
Signed-off-by: Logan Nguyen <[email protected]> Revert "fix: removed name field in JsonRpcError class" This reverts commit c8024e3. Signed-off-by: Logan Nguyen <[email protected]> Reapply "fix: removed name field in JsonRpcError class" This reverts commit e64d1fc.
quiet-node
force-pushed
the
2589-relay-error-response-is-not-conforming-to-the-json-rpc-20-specification
branch
from
e64d1fc to
f37d253
Compare
|
😓 yes I reverted the changes to test the Tests/Tests CI and it still failed for some reasons. |
quiet-node
deleted the
2589-relay-error-response-is-not-conforming-to-the-json-rpc-20-specification
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR removes the
namefield in JsonRpcError class to conform to the JSON-RPC 2.0 Specification. Many tests were updated to apply this new changes.Related issue(s):
Fixes #2589
Notes for reviewer:
Checklist