Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional equivalence tests for CALL, STATICCALL and DELEGATECALL #2515

Merged
merged 15 commits into from
Jun 21, 2024
Merged

Additional equivalence tests for CALL, STATICCALL and DELEGATECALL #2515

merged 15 commits into from
Jun 21, 2024

Conversation

emilevgenievgeorgiev
Copy link
Contributor

Description:

  • Added new functions to equivalence contract
  • Added tests for CALL, STATICCALL and DELEGATECALL opcodes

Related issue(s):
#2012

Fixes #

Notes for reviewer:

Checklist

Aleksandrina Todorova and others added 12 commits April 2, 2024 16:58
@nickeynikolovv
e2e(tests):Add tests for equivalence
b188cac 
Signed-off-by: Aleksandrina Todorova <[email protected]>
@nickeynikolovv
Added new method for contractCall with amount
fd2bba2 
Signed-off-by: Aleksandrina Todorova <[email protected]>
@konstantinabl @nickeynikolovv
Propagate error from execute transaction upwards to other methods
21b0c39 
Signed-off-by: Konstantina Blazhukova <[email protected]>
@nickeynikolovv
Update tests to use testRejection
ecc70e8 
Signed-off-by: Aleksandrina Todorova <[email protected]>
@nickeynikolovv
Added additional tests for internal calls and fixed some of the previ…
c301447 
…ous tests for direct calls

Signed-off-by: Nikolay Nikolov <[email protected]>
@nickeynikolovv
- added additional tests
5175e0d 
Signed-off-by: Nikolay Nikolov <[email protected]>
@nickeynikolovv
- added more tests, also added a function for creating a fungible token
b629175 
Signed-off-by: Nikolay Nikolov <[email protected]>
@emilevgenievgeorgiev
Added equivalence tests
55599ed 
Signed-off-by: emilevgenievgeorgiev <[email protected]>
@emilevgenievgeorgiev
Added and updated equivalence tests for internal calls
00c0f93 
Signed-off-by: emilevgenievgeorgiev <[email protected]>
@emilevgenievgeorgiev
Added and updated equivalence tests for internal calls
801e31b 
Signed-off-by: emilevgenievgeorgiev <[email protected]>
@emilevgenievgeorgiev
Updated equivalence tests
73aed43 
Signed-off-by: emilevgenievgeorgiev <[email protected]>
@emilevgenievgeorgiev
code cleanup
a41cc8f 
Signed-off-by: emilevgenievgeorgiev <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024 •
edited
Loading

Tests

    2 files  150 suites   15s ⏱️
837 tests 836 ✔️ 1 💤 0 ❌
849 runs  848 ✔️ 1 💤 0 ❌

Results for commit 681b072.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024 •
edited
Loading

Acceptance Tests

     25 files     405 suites   41m 57s ⏱️
   602 tests    592 ✔️   3 💤   7 ❌
1 476 runs  1 447 ✔️ 17 💤 12 ❌

Results for commit 681b072.

♻️ This comment has been updated with latest results.

@emilevgenievgeorgiev emilevgenievgeorgiev marked this pull request as ready for review June 6, 2024 14:15
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.5% Duplication on New Code

See analysis details on SonarCloud

ebadiere
ebadiere approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@ebadiere ebadiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG.

nickeynikolovv
nickeynikolovv approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@nickeynikolovv nickeynikolovv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebadiere ebadiere merged commit 4197a5f into main Jun 21, 2024
32 of 35 checks passed
@ebadiere ebadiere deleted the add_additional_tests_equivalence branch June 21, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickeynikolovv nickeynikolovv nickeynikolovv approved these changes

@ebadiere ebadiere ebadiere approved these changes

@AlfredoG87 AlfredoG87 Awaiting requested review from AlfredoG87

@Nana-EC Nana-EC Awaiting requested review from Nana-EC Nana-EC is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emilevgenievgeorgiev @ebadiere @nickeynikolovv @konstantinabl