feat: added support for eth_getTransactionReceipt() to the WS server (#2274) #2297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quiet-node
requested review from
AlfredoG87,
ebadiere,
georgi-l95,
Ivo-Yankov,
a team and
Nana-EC
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2297 +/- ##
=======================================
Coverage 75.15% 75.15%
=======================================
Files 13 13
Lines 644 644
Branches 118 118
=======================================
Hits 484 484
Misses 115 115
Partials 45 45 ☔ View full report in Codecov by Sentry. |
quiet-node
force-pushed
the
2274-implement-gettransactionreceipttransactionhashin-the-websocket-server
branch
from
77265d4 to
4d48758
Compare
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
quiet-node
force-pushed
the
2274-implement-gettransactionreceipttransactionhashin-the-websocket-server
branch
from
4d48758 to
fbe4c78
Compare
Signed-off-by: Logan Nguyen <[email protected]>
ebadiere
reviewed
Apr 9, 2024
| afterEach(async () => { | ||
| if (wsProvider) { | ||
| await wsProvider.destroy(); | ||
| await new Promise((resolve) => setTimeout(resolve, 1000)); |
There was a problem hiding this comment.
What are we waiting for here? Can this be replaced by some kind of check such as the wsProvider being destroyed or undefined?
ebadiere
reviewed
Apr 9, 2024
| afterEach(async () => { | ||
| if (wsProvider) { | ||
| await wsProvider.destroy(); | ||
| await new Promise((resolve) => setTimeout(resolve, 1000)); |
Signed-off-by: Logan Nguyen <[email protected]> Revert "fix: removed timer after connecting and disconnecting wsProvider" This reverts commit 8cc42b8. a Signed-off-by: Logan Nguyen <[email protected]>
quiet-node
force-pushed
the
2274-implement-gettransactionreceipttransactionhashin-the-websocket-server
branch
from
8cc42b8 to
edd503b
Compare
|
ebadiere
deleted the
2274-implement-gettransactionreceipttransactionhashin-the-websocket-server
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue(s):
Fixes #2274
Notes for reviewer:
Checklist