feat: added support for getTransactionByHash endpoint in the WS server (#2273) #2295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
quiet-node
requested review from
AlfredoG87,
ebadiere,
georgi-l95,
Ivo-Yankov,
a team and
Nana-EC
as code owners
Signed-off-by: Logan Nguyen <[email protected]>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2295 +/- ##
=======================================
Coverage 75.15% 75.15%
=======================================
Files 13 13
Lines 644 644
Branches 118 118
=======================================
Hits 484 484
Misses 115 115
Partials 45 45 ☔ View full report in Codecov by Sentry. |
quiet-node
changed the title
AlfredoG87
approved these changes
Apr 5, 2024
Comment on lines
+186
to
+188
| socketIdPrefix, | ||
| requestIdPrefix, | ||
| connectionIdPrefix, |
There was a problem hiding this comment.
question, what is the difference between socketId and connectionId.
There was a problem hiding this comment.
This is actually a good question they are actually both the same. I have made an update to remove the socketId in the next PR
ebadiere
deleted the
2273-implement-gettransactiontransactionhash-in-the-websocket-server
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds support and test coverage for
eth_getTransactionByHash(txHash)endpoint to the websocket server.This PR also slightly modify utils functions in ws-server package to better suit the new API
Related issue(s):
Fixes #2273
Notes for reviewer:
Checklist