-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add compression mode for BlockAsFileWriter #387
feat: add compression mode for BlockAsFileWriter #387
Conversation
...r/src/main/java/com/hedera/block/server/persistence/storage/compression/ZstdCompression.java
Outdated
Show resolved
Hide resolved
server/src/main/java/com/hedera/block/server/persistence/storage/compression/Compression.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/hedera/block/server/persistence/storage/compression/AbstractCompression.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that the Compression class should receive a stream and return a stream. otherwise looks good.
server/src/main/java/com/hedera/block/server/persistence/PersistenceInjectionModule.java
Outdated
Show resolved
Hide resolved
server/src/main/java/com/hedera/block/server/persistence/PersistenceInjectionModule.java
Outdated
Show resolved
Hide resolved
server/src/main/java/com/hedera/block/server/persistence/storage/PersistenceStorageConfig.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/hedera/block/server/persistence/storage/compression/AbstractCompression.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/com/hedera/block/server/persistence/storage/compression/ZstdCompression.java
Outdated
Show resolved
Hide resolved
e61a459
to
e85fe16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
server/src/main/java/com/hedera/block/server/persistence/storage/PersistenceStorageConfig.java
Outdated
Show resolved
Hide resolved
server/src/main/java/com/hedera/block/server/persistence/storage/PersistenceStorageConfig.java
Outdated
Show resolved
Hide resolved
server/src/main/java/com/hedera/block/server/persistence/storage/PersistenceStorageConfig.java
Outdated
Show resolved
Hide resolved
server/src/main/java/com/hedera/block/server/persistence/storage/PersistenceStorageConfig.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
4be98f4
to
3a44365
Compare
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
...r/src/main/java/com/hedera/block/server/persistence/storage/compression/NoOpCompression.java
Show resolved
Hide resolved
server/src/main/java/com/hedera/block/server/persistence/storage/PersistenceStorageConfig.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Atanas Atanasov <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #387 +/- ##
============================================
+ Coverage 96.99% 97.06% +0.07%
- Complexity 400 416 +16
============================================
Files 80 82 +2
Lines 1429 1465 +36
Branches 94 96 +2
============================================
+ Hits 1386 1422 +36
Misses 32 32
Partials 11 11
|
Description:
Related issue(s):
Fixes #282
Notes for reviewer:
TBD
Checklist