js-based view-source #106
Draft
js-based view-source #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KellerFuchs
previously requested changes
Oct 11, 2016
server.py
Outdated
| response.headers['X-Content-Type-Options'] = 'nosniff' | ||
| response.headers['X-Frame-Options'] = 'DENY' | ||
| response.headers['X-XSS-Protection'] = '1; mode=block' | ||
| response.headers['Access-Control-Allow-Origin'] = 'https://hashbang.sh/' |
src/scripts.js
Outdated
| var link = document.createElement("link"); | ||
| link.type = "image/png"; | ||
| link.rel = "icon"; | ||
| link.href = "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQAQAAAAA3iMLMAAAABGdBTUEAALGPC/xhBQAAACBjSFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAAmJLR0QAAd2KE6QAAAAYSURBVAjXY2CAAck+EKp/B0II9gMoGwYA4+MJkeae/NUAAAAldEVYdGRhdGU6Y3JlYXRlADIwMTQtMDUtMTdUMTM6MzI6MTMtMDQ6MDB7pieOAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDE0LTA1LTE3VDEzOjMxOjQ4LTA0OjAwqyt+rwAAAABJRU5ErkJggg=="; |
There was a problem hiding this comment.
If we are moving this around, can't we put it directly in the HTML?
src/scripts.js
Outdated
| sourceEl.removeAttribute("href"); | ||
| sourceEl.onclick = function(){ | ||
| var client = new XMLHttpRequest(); | ||
| client.open('GET', 'http://localhost:8080/'); |
There was a problem hiding this comment.
NOPE, wrong URL.
(Also, would be forbidden by CSP)
KellerFuchs
reviewed
Feb 26, 2017
There was a problem hiding this comment.
@lrvick I implemented the changes I requested.
Please answer the question regarding the CORS header.
@RyanSquared Please review, since there are now commits I wrote in here.
KellerFuchs
dismissed
their stale review
Changes implemented. One question left.
KellerFuchs
force-pushed
the
view-source-js
branch
from
14effa2 to
526e0f3
Compare
|
Rebased atop the current |
daurnimator
reviewed
Mar 1, 2017
| var client = new XMLHttpRequest(); | ||
| client.open('GET', 'https://hashbang.sh/'); | ||
| client.onreadystatechange = function() { | ||
| console.log(client.responseText) |
daurnimator
reviewed
Mar 1, 2017
| var sourceText = document.createTextNode(client.responseText) | ||
| div.appendChild(sourceText) | ||
| div.id = "source" | ||
| document.getElementsByTagName("html")[0].appendChild(div); |
There was a problem hiding this comment.
Instead of document.getElementsByTagName("html")[0] why not use document.firstElementChild?
But also, shouldn't you be appending to document.body anyway?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge, still some CSS issues to work out (can't scroll).
Overall implementation tested/works.