Fix currency input (twentyhq#7469)

Fix twentyhq#7458
harshit078 · Oct 14, 2024 · 78d5815 · 78d5815
1 parent 22f0fb3
commit 78d5815
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/packages/twenty-front/src/modules/ui/field/display/components/CurrencyDisplay.tsx b/packages/twenty-front/src/modules/ui/field/display/components/CurrencyDisplay.tsx
@@ -5,6 +5,7 @@ import { FieldCurrencyValue } from '@/object-record/record-field/types/FieldMeta
 import { SETTINGS_FIELD_CURRENCY_CODES } from '@/settings/data-model/constants/SettingsFieldCurrencyCodes';
 import { formatAmount } from '~/utils/format/formatAmount';
 import { isDefined } from '~/utils/isDefined';
+import { isUndefinedOrNull } from '~/utils/isUndefinedOrNull';
 
 type CurrencyDisplayProps = {
   currencyValue: FieldCurrencyValue | null | undefined;
@@ -29,10 +30,9 @@ export const CurrencyDisplay = ({ currencyValue }: CurrencyDisplayProps) => {
     ? SETTINGS_FIELD_CURRENCY_CODES[currencyValue?.currencyCode]?.Icon
     : null;
 
-  const amountToDisplay =
-    currencyValue?.amountMicros != null
-      ? currencyValue?.amountMicros / 1000000
-      : null;
+  const amountToDisplay = isUndefinedOrNull(currencyValue?.amountMicros)
+    ? null
+    : currencyValue?.amountMicros / 1000000;
 
   if (!shouldDisplayCurrency) {
     return <StyledEllipsisDisplay>{0}</StyledEllipsisDisplay>;

diff --git a/packages/twenty-front/src/modules/ui/field/input/components/CurrencyInput.tsx b/packages/twenty-front/src/modules/ui/field/input/components/CurrencyInput.tsx
@@ -144,6 +144,7 @@ export const CurrencyInput = ({
         placeholder={placeholder}
         autoFocus={autoFocus}
         value={value}
+        unmask
       />
     </StyledContainer>
   );

diff --git a/packages/twenty-server/src/engine/utils/should-seed-workspace-favorite.ts b/packages/twenty-server/src/engine/utils/should-seed-workspace-favorite.ts
@@ -5,5 +5,5 @@ export const shouldSeedWorkspaceFavorite = (
   objectMetadataMap,
 ): boolean =>
   objectMetadataId !==
-    objectMetadataMap[STANDARD_OBJECT_IDS.workflowVersion].id &&
-  objectMetadataId !== objectMetadataMap[STANDARD_OBJECT_IDS.workflowRun].id;
+    objectMetadataMap[STANDARD_OBJECT_IDS.workflowVersion]?.id &&
+  objectMetadataId !== objectMetadataMap[STANDARD_OBJECT_IDS.workflowRun]?.id;