Clarify Connected behavior
#34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glopesdev
reviewed
Apr 10, 2024
Co-authored-by: glopesdev <[email protected]>
bruno-f-cruz
commented
Apr 18, 2024
glopesdev
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially addresses issue #14 by explicitly stating what is the expected definition of
connectedbetween device and host.Since the harp protocol can be implemented on top of distinct transport layers, we simply define that each transport layer/implementation is responsible for defining its own way to make sure that the connection is alive. We suggest that for USB connections, the DTR pin can be leveraged.
The immediate implication of this decision is that the C# Bonsai client will set this DTR flag high by default so that devices that can leverage this behavior will now be able to do so.