Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [PL-58650]: Terraform Changes for Add support for configuring recovery duration in AWS Secrets Manager Connector for secret deletion flow #1140

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sahibaHarness
Copy link
Contributor

Title: [Component/Feature] Short Description of the Change
This PR covers changes to give user ability to retrieve a deleted secret in AWS Secret Manager if accidentaly deleted from Harness. When configuring a AWS SM connector in Harness use can now choose between two additional fields:

Tested for:

Created connector with recovery period of 15 days
Error is thrown when recovery period is selected as 5
Created connector with ForceDeleteWithoutRecovery as true

Go sdk PR:
harness/harness-go-sdk#620

harness core PR:
https://harness0.harness.io/ng/account/l7B_kbSEQD2wjrM7PShm5w/module/code/orgs/PROD/projects/Harness_Commons/repos/harness-core/pulls/100093

Assume Role using STS on Delegate Pasted Graphic 31 Credertial Type ©

Summary:
Provide a brief overview of what the PR does and why it is needed.

Details:
Explain the changes in detail, including any relevant context or background information.

Related Issues:
Reference any related issues or tickets

Testing Instructions:
Describe how the changes were tested. Include any test cases or steps to verify the functionality.
Please include the below test scenario with your changes.

  • Create the resource and execute terraform apply. (Verify the resource is created)
  • Execute terraform apply again without any changes. (Verify no changes should be done)
  • Update the resource and execute terraform apply. (Verify the resource updated successfully)
  • Remove the content from resource file and execute terraform apply. (Verify the resource has been deleted)
  • Add again the resource and execute the terraform apply. (Verify the resource is created)
  • Verify the import the resource file is working fine.
  • In case of remote entity, Verify for both default and non default branch.

Screenshots:
Include before and after screenshots to visually demonstrate the changes.
Checklist:

  • Code changes are well-documented.
  • Tests have been added/updated.
  • Changes have been tested locally.
  • Documentation has been updated.
PR Check triggers
  • Build: trigger build
  • Sub Category Field Check: trigger subcategoryfieldcheck
  • gitleaks: trigger gitleaks

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

…ecovery duration in AWS Secrets Manager Connector for secret deletion flow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants