feat: [PL-58650]: Terraform Changes for Add support for configuring recovery duration in AWS Secrets Manager Connector for secret deletion flow #1140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: [Component/Feature] Short Description of the Change
This PR covers changes to give user ability to retrieve a deleted secret in AWS Secret Manager if accidentaly deleted from Harness. When configuring a AWS SM connector in Harness use can now choose between two additional fields:
Tested for:
Created connector with recovery period of 15 days
Error is thrown when recovery period is selected as 5
Created connector with ForceDeleteWithoutRecovery as true
Go sdk PR:
harness/harness-go-sdk#620
harness core PR:
https://harness0.harness.io/ng/account/l7B_kbSEQD2wjrM7PShm5w/module/code/orgs/PROD/projects/Harness_Commons/repos/harness-core/pulls/100093
Summary:
Provide a brief overview of what the PR does and why it is needed.
Details:
Explain the changes in detail, including any relevant context or background information.
Related Issues:
Reference any related issues or tickets
Testing Instructions:
Describe how the changes were tested. Include any test cases or steps to verify the functionality.
Please include the below test scenario with your changes.
Screenshots:
Include before and after screenshots to visually demonstrate the changes.
Checklist:
PR Check triggers
trigger build
trigger subcategoryfieldcheck
trigger gitleaks