Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [AH-781]: Support allOf, oneOf keys along with properties key and update join condition for allOf and oneOf #37

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

shivanand-harness
Copy link
Contributor

Changes:

  1. Support allOf, oneOf keys along with properties key
  2. Update join condition for allOf and oneOf

Summary

For below schema

RegistryConfig:
  description: SubConfig specific for Virtual or Upstream Registry
  discriminator:
    mapping:
      UPSTREAM: '#/components/schemas/UpstreamConfig'
      VIRTUAL: '#/components/schemas/VirtualConfig'
    propertyName: type
  oneOf:
  - $ref: '#/components/schemas/VirtualConfig'
  - $ref: '#/components/schemas/UpstreamConfig'
  properties:
    type:
      $ref: '#/components/schemas/RegistryType'
  required:
  - type
  type: object

generated output

export type RegistryConfig = VirtualConfig & UpstreamConfig;

expected output

export type RegistryConfig = (VirtualConfig | UpstreamConfig) & {
    type: RegistryType;
};

Screenshots

NA

Contributor license agreement

…And update join condition for allOf and oneOf
Copy link

@avinashmadhwani02 avinashmadhwani02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
i think we need to bump the package version. Also this is going to be a breaking change.
As discussed please increase the major version

@abhinavrastogi-harness
Copy link
Collaborator

@vardanbansal-harness please review. i remember we made some breaking changes for code service page headers recently.. was that only on the client package, or did it touch the oats cli as well?

Copy link
Contributor

@vardanbansal-harness vardanbansal-harness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@vardanbansal-harness
Copy link
Contributor

@vardanbansal-harness please review. i remember we made some breaking changes for code service page headers recently.. was that only on the client package, or did it touch the oats cli as well?

@abhinavrastogi-harness Those changes were limited to packages/plugin-react-query only. We didn't have to change anything in packages/cli.

@shivanand-harness shivanand-harness merged commit e19cacd into main Dec 13, 2024
4 checks passed
@shivanand-harness shivanand-harness deleted the feat-AH-781 branch December 13, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants