fix: [PL-56199]: support Open API yaml URL with Github API

harness · Aug 18, 2024 · 00fb26d · 00fb26d
1 parent 4ec8fc3
commit 00fb26d
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/.github/workflows/pull_request.yaml b/.github/workflows/pull_request.yaml
@@ -38,7 +38,6 @@ jobs:
         run: pnpm install
       - name: Lint
         run: |
-          pwd
           pnpm run -r build
           pnpm run -r lint
   typecheck:

diff --git a/packages/cli/src/helpers.mts b/packages/cli/src/helpers.mts
@@ -10,10 +10,11 @@ import { has } from 'lodash-es';
 
 const DIR_NAME = getDirNameForCurrentFile(import.meta);
 
-export const GITHUB_PAT = process.env.GITHUB_PAT;
+// helpers when when working with url to generate service
 const DEFAULT_BRANCH = 'develop';
 const URL_PREFIX = 'https://api.github.com/repos/harness/harness-core/contents/';
-// const yamlPath = '120-ng-manager/contracts/openapi/v1/openapi.yaml';
+
+export const GITHUB_PAT = process.env.GITHUB_PAT;
 export const GITHUB_API_ENDPOINT_URL = (yamlPath: string) =>
 	`${URL_PREFIX}${yamlPath}?ref=${DEFAULT_BRANCH}`;
 

diff --git a/packages/cli/src/loadSpecFromFileOrUrl.mts b/packages/cli/src/loadSpecFromFileOrUrl.mts
@@ -46,9 +46,12 @@ export async function loadSpecFromFileOrUrl(config: IServiceConfig): Promise<IPl
 	} else if (config.url) {
 		// read from URL
 		logInfo('Fetching data from URL');
-		const abcd = 'platform-service/modules/notification-service/contracts/openapi/v1/openapi.yaml';
 
-		const configUrl = process.env.CI ? config.url : GITHUB_API_ENDPOINT_URL(abcd);
+		if (!GITHUB_PAT) {
+			throw new Error('GITHUB PAT is not defined, please set GITHUB_PAT environment variable');
+		}
+
+		const configUrl = process.env.CI ? config.url : GITHUB_API_ENDPOINT_URL(config.url);
 		const configHeaders = process.env.CI
 			? {}
 			: { headers: { Authorization: `Bearer ${GITHUB_PAT}` } };