Skip to content

Commit

Permalink
Merge pull request #140 from harness/PL-58400
Browse files Browse the repository at this point in the history
fix: [PL-58400]: Putting re-write behind if condition to not render if not provided in override
  • Loading branch information
bharatgoelharness authored Nov 7, 2024
2 parents dca6472 + 83277ef commit 292a129
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/common/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: library
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 1.3.67
version: 1.3.68

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
2 changes: 2 additions & 0 deletions src/common/templates/_virtualservice.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ spec:
- uri:
{{ $object.pathMatchType }}: {{ include "harnesscommon.tplvalues.render" ( dict "value" $path.path "context" $) }}
name: {{ (cat $objName "-" $i) | nospace }}
{{- if $object.pathRewrite }}
rewrite:
{{- if eq $object.pathMatchType "regex" }}
uriRegexRewrite:
Expand All @@ -56,6 +57,7 @@ spec:
{{- else }}
uri: {{ include "harnesscommon.tplvalues.render" ( dict "value" $object.pathRewrite "context" $) }}
{{- end }}
{{- end }}
route:
- destination:
host: {{ $serviceName }}
Expand Down

0 comments on commit 292a129

Please sign in to comment.