Wrap source with double quotes (#5)

harness · Sep 2, 2021 · 9f2209a · 9f2209a
1 parent 4796071
commit 9f2209a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/docker/Dockerfile b/docker/Dockerfile
@@ -1,7 +1,7 @@
-FROM alpine:3.6 as alpine
+FROM alpine:3.12 as alpine
 RUN apk add -U --no-cache ca-certificates
 
-FROM alpine:3.6
+FROM alpine:3.12
 ENV GODEBUG netdns=go
 
 COPY --from=alpine /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/

diff --git a/plugin/plugin.go b/plugin/plugin.go
@@ -37,19 +37,19 @@ func Exec(ctx context.Context, args Args) error {
 		return fmt.Errorf("url needs to be set")
 	}
 
-	cmdArgs := []string{"jfrog", "rt", "u", fmt.Sprintf("--url=%s", args.URL)}
+	cmdArgs := []string{"jfrog", "rt", "u", fmt.Sprintf("--url %s", args.URL)}
 	if args.Retries != 0 {
 		cmdArgs = append(cmdArgs, fmt.Sprintf("--retries=%d", args.Retries))
 	}
 
 	// Set authentication params
 	if args.Username != "" && args.Password != "" {
-		cmdArgs = append(cmdArgs, fmt.Sprintf("--user $PLUGIN_USERNAME"))
-		cmdArgs = append(cmdArgs, fmt.Sprintf("--password $PLUGIN_PASSWORD"))
+		cmdArgs = append(cmdArgs, "--user $PLUGIN_USERNAME")
+		cmdArgs = append(cmdArgs, "--password $PLUGIN_PASSWORD")
 	} else if args.APIKey != "" {
-		cmdArgs = append(cmdArgs, fmt.Sprintf("--apikey $PLUGIN_API_KEY"))
+		cmdArgs = append(cmdArgs, "--apikey $PLUGIN_API_KEY")
 	} else if args.AccessToken != "" {
-		cmdArgs = append(cmdArgs, fmt.Sprintf("--access-token $PLUGIN_ACCESS_TOKEN"))
+		cmdArgs = append(cmdArgs, "--access-token $PLUGIN_ACCESS_TOKEN")
 	} else {
 		return fmt.Errorf("either username/password, api key or access token needs to be set")
 	}
@@ -60,7 +60,7 @@ func Exec(ctx context.Context, args Args) error {
 	if args.Target == "" {
 		return fmt.Errorf("target path needs to be set")
 	}
-	cmdArgs = append(cmdArgs, args.Source, args.Target)
+	cmdArgs = append(cmdArgs, fmt.Sprintf("\"%s\"", args.Source), args.Target)
 	cmdStr := strings.Join(cmdArgs[:], " ")
 
 	cmd := exec.Command("sh", "-c", cmdStr)