Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRM Plugin for IDP #98

Merged
merged 5 commits into from
Nov 16, 2023
Merged

SRM Plugin for IDP #98

merged 5 commits into from
Nov 16, 2023

Conversation

shash-harness
Copy link
Contributor

@shash-harness shash-harness commented Nov 16, 2023

Describe your changes

This is the code for SRM Plugin for IDP.

Checklist

  • I've documented the changes in the PR description.
  • I've tested this change either in PR or local environment.

Contributor license agreement

@shash-harness shash-harness requested review from a team as code owners November 16, 2023 08:59
@shash-harness shash-harness marked this pull request as draft November 16, 2023 09:20
@@ -0,0 +1,211 @@
import React from 'react';

export const HeartIcon = () => (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following icons not available in Material UI?

Copy link
Contributor Author

@shash-harness shash-harness Nov 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No ,these are from core ui harness, so have added in this manner.

@shash-harness shash-harness marked this pull request as ready for review November 16, 2023 11:56
Copy link
Member

@Debanitrkl Debanitrkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@jenil-harness jenil-harness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jenil-harness jenil-harness merged commit 39d52df into main Nov 16, 2023
1 check passed
@jenil-harness jenil-harness deleted the SRM-Plugin branch November 16, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants