Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [IAC-2429]: IACM plugin unauthourized message #150

Merged
merged 1 commit into from
Sep 10, 2024
Merged

feat: [IAC-2429]: IACM plugin unauthourized message #150

merged 1 commit into from
Sep 10, 2024

Conversation

simonharness
Copy link
Contributor

Describe your changes

Handle 401 for IACM/ resources tab and prevent infinite spinner if unauthorized

Screenshot 2024-09-09 at 14 27 50

Checklist

  • I've documented the changes in the PR description.
  • I've tested this change either in PR or local environment.

Contributor license agreement

@simonharness simonharness requested review from a team as code owners September 9, 2024 14:10
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Debanitrkl
Debanitrkl approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@Debanitrkl Debanitrkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@simonharness simonharness force-pushed the IAC-2429-display-unauthorised-message branch from 64f2a47 to b6dbf42 Compare September 10, 2024 09:30
@simonharness simonharness force-pushed the IAC-2429-display-unauthorised-message branch from b6dbf42 to ed9f3a6 Compare September 10, 2024 09:30
@simonharness simonharness merged commit 735de90 into main Sep 10, 2024
1 check passed
@simonharness simonharness deleted the IAC-2429-display-unauthorised-message branch September 10, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Debanitrkl Debanitrkl Debanitrkl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonharness @CLAassistant @Debanitrkl