Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the service URL to match the gitsync URL #144

Merged
merged 5 commits into from
Aug 21, 2024

Conversation

Debanitrkl
Copy link
Member

Describe your changes

Checklist

  • I've documented the changes in the PR description.
  • I've tested this change either in PR or local environment.

Contributor license agreement

@Debanitrkl Debanitrkl requested review from a team as code owners August 21, 2024 04:20
projectIds: urlParams.params.projectId as string,
envFromUrl: envFromUrl,
envFromUrl,
};
}

const serviceUrlParams: any = serviceUrlMatch(selectedPipelineUrl);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const serviceUrlParams: any = serviceUrlMatch(selectedPipelineUrl);
const serviceUrlParams: any = serviceUrlMatch(selectedPipelineUrl.split('?')[0]);

@Debanitrkl Debanitrkl enabled auto-merge (squash) August 21, 2024 09:17
Copy link
Contributor

@jenil-harness jenil-harness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Debanitrkl Debanitrkl merged commit 67e12c4 into harness:main Aug 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants