Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added bearer prefix to ci/cd plugin token #139

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

Debanitrkl
Copy link
Member

Describe your changes

Checklist

  • I've documented the changes in the PR description.
  • I've tested this change either in PR or local environment.

Contributor license agreement

@Debanitrkl Debanitrkl requested review from a team as code owners August 6, 2024 08:35
Copy link
Contributor

@jenil-harness jenil-harness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +18 to +23
const value = token && token === apiToken ? `Bearer ${token}` : token;

const headers = new Headers();
if (value) {
headers.append('Authorization', value);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can look into extracting the function to a common file.

@Debanitrkl Debanitrkl merged commit de7ff8c into harness:main Aug 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants