proof-of-concept decode XLS from ByteString #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added two functions to decode a
ByteString
. The functiondecodeXlsByteString
is just a wrapper arounddecodeXlsIO
as suggested by Erik Rybakken. The functiondecodeXlsByteString'
makes use of the libxls function that can open buffers. The latter is experimental and when proven to work properly should replace the former. Since this is my first FFI project, someone please review the definition ofData.Xls.toCBuffer
and theStorable XLSError
instance. Specifically, how does one determine the correctsizeOf
a C enum? On my machine,sizeof(xls_error_t)
returns 4 with gcc, but that might be different with different compiler/architecture combinations.