make CampaignCreationSegmentOptions fields omitempty #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zeekay @bradleyfalk @tw1nk @Rishub21 Can someone please review? |
|
Looks good, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recipients.segment_optsin MailChimp API docs is optional, hence I have modified theCampaignCreationSegmentOptionsstruct accordingly.I did not like the solution in #53 and #60 which makes
SegmentOptionsa pointer because it is breaking change. However that is the only way to use theomitemptytag on a struct field.My solution is to instead place
omitemptyon all the fields within the struct. When theCampaignCreationRecipientsis JSON marshalled andSegmentOptionsis not provided, it will generate"segment_opts": {}which behaves the same at it being omitted in the MailChimp API. This solution also does not break existing usage.