Upgraded for Python3.6+ and PyTorch 1.1.0+ #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| from PIL import Image, ImageFont, ImageDraw | ||
| from copy import deepcopy | ||
|
|
||
| from miscc.config import cfg | ||
| from miscc.utils import mkdir_p | ||
| from model import G_NET, D_NET64, D_NET128, D_NET256, D_NET512, D_NET1024, INCEPTION_V3 | ||
|
|
||
| from tensorboardX import FileWriter, summary |
There was a problem hiding this comment.
I had to install tensorboardX dependency from https://github.com/lanpa/tensorboardX, this is not included in dependency section in the README.md
There was a problem hiding this comment.
Gotcha. I had tensorboard in the README.md not tensorboardX. Will update that. Thanks
|
What holds back this PR? |
sursu
suggested changes
Jan 19, 2020
| from PIL import Image, ImageFont, ImageDraw | ||
| from copy import deepcopy | ||
|
|
||
| from miscc.config import cfg | ||
| from miscc.utils import mkdir_p | ||
| from model import G_NET, D_NET64, D_NET128, D_NET256, D_NET512, D_NET1024, INCEPTION_V3 | ||
|
|
||
| from tensorboardX import FileWriter, summary |
There was a problem hiding this comment.
I would suggest there to be used:
from torch.utils.tensorboard import summary, FileWriter
HadiZayer
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded all the main files for Python3.6+ and PyTorch 1.1.0+ usage