Set archive modification time to current time

"github.com/klauspost/compress/gzip".Writer doesn't support omitting the modification time in the header of a gzip stream.
hansmi · Nov 23, 2022 · 4bcd813 · 4bcd813
1 parent 275fa7c
commit 4bcd813
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/internal/snapshotstream/stream.go b/internal/snapshotstream/stream.go
@@ -103,6 +103,7 @@ func (s *Stream) writeTo(w io.Writer) (err error) {
 		gzipWriter := gzip.NewWriter(w)
 		gzipWriter.Header.Name = strings.TrimSuffix(filepath.Base(s.Filename), filepath.Ext(s.Filename))
 		gzipWriter.Header.Comment = fmt.Sprintf("Prometheus snapshot %s", s.name)
+		gzipWriter.Header.ModTime = time.Now()
 
 		defer multierr.AppendInvoke(&err, multierr.Close(gzipWriter))
 

diff --git a/internal/snapshotstream/stream_test.go b/internal/snapshotstream/stream_test.go
@@ -154,7 +154,7 @@ func TestStream(t *testing.T) {
 					t.Errorf("gzip.NewReader() failed: %v", err)
 				}
 
-				if diff := cmp.Diff(tc.wantGzipHeader, gzReader.Header, cmpopts.IgnoreFields(gzip.Header{}, "OS")); diff != "" {
+				if diff := cmp.Diff(tc.wantGzipHeader, gzReader.Header, cmpopts.IgnoreFields(gzip.Header{}, "OS", "ModTime")); diff != "" {
 					t.Errorf("Gzip header diff (-want +got):\n%s", diff)
 				}